Skip to content

OpenConfig Platform Transceiver HLD #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nakano-omw
Copy link
Contributor

OpenConfig support for Platform Transceiver.

Add support for following features:

  • serial-no
  • connector-type
  • vendor
  • vendor-part
  • date-code
  • supply-voltage
  • laser-temperature
  • output-power
  • input-power
  • laser-bias-current

@nakano-omw
Copy link
Contributor Author

nakano-omw commented Nov 27, 2024

This HLD was reviewed by the UMF WG on November 27, 2024.

- output-power
- input-power
- laser-bias-current

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about high/low warning/critical thresholds for temperature and voltage? These should also be encoded in transceiver DOM values.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion.
We found that we can fetch the value of thresholds.
As a first step, we are thinking to implement the functions to get the value of the following thresholds.
components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/output-power-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/output-power-lower components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/input-power-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/input-power-lower components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/laser-bias-current-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[CRITICAL]/state/laser-bias-current-lower
components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/output-power-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/output-power-lower components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/input-power-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/input-power-lower components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/laser-bias-current-upper components/component[transceiver_XXX]/transceiver/thresholds/threshold[WARNING]/state/laser-bias-current-lower

@nakano-omw
Copy link
Contributor Author

@zhangyanzhao I would like to see it added to SONiC 202505 Release

Signed-off-by: Kanji Nakano <kanji.nakano@ntt.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@nakano-omw
Copy link
Contributor Author

@jeff-yin I have updated the HLD with the changes related to additional support for CRITICAL/WARNING threshold parameters. In addition, I have also submitted a code PR for the support. I would appreciate it if you could review the code. Thank you!
sonic-net/sonic-mgmt-common#160

@zhangyanzhao
Copy link
Collaborator

@nakano-omw I added this feature to 202505 release. Can you please add the code PRs by referring to #806 ? Thanks.

@anilpannala anilpannala moved this from 🏗 In Progress to MovedToBacklog in SONiC 202505 Release May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: MovedToBacklog
Development

Successfully merging this pull request may close these issues.

6 participants