-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSTP Documentation: Enhanced, corrected and refined the existing content #1877
base: master
Are you sure you want to change the base?
MSTP Documentation: Enhanced, corrected and refined the existing content #1877
Conversation
/azp run |
|
No pipelines are associated with this pull request. |
/easycla |
e66536c
to
8b47aba
Compare
/azp run |
No pipelines are associated with this pull request. |
@ridahanif96 @divyachandralekha @adyeung Kindly review and approve the MSTP documentation changes |
Hello @adyeung, a gentle reminder! Can you please help get this reviewed at the earliest? |
Hello @adyeung, another gentle reminder! Kindly help get this reviewed at the earliest... |
|
||
- debug spanning_tree dump global | ||
- debug spanning_tree dump mst global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove 'mst' keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the 'mst' keyword here, it would be not in line with the MST instance specific debug command defined below. Please clarify if that's correct as per the intended design.
``` | ||
admin@sonic: show spanning_tree detail | ||
admin@sonic: show spanning_tree mst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove 'mst' keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was done to be inline with this command header above. Please clarify if the 'mst' keyword needs to be removed at both the places and is as per the intended design.
## Clear Commands | ||
- sonic-clear spanning_tree statistics | ||
- sonic-clear spanning_tree mst statistics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove 'mst' keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the 'mst' keyword here, it would be not in line with the MST instance specific clear command defined below. Please clarify if that's correct as per the intended design.
- Default : Auto | ||
|
||
|
||
**Note : These functionalities need to be explicitly enabled.** | ||
|
||
## Show Commands | ||
|
||
- show spanning_tree mst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify if 'mst' keyword has to be removed from the command header on this line as well
``` | ||
|
||
- show spanning_tree mst detail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command header declared in this line have 'mst' keyword, but the command on line 540 below doesnt include it. Please clarify what is the correct command here?
## Clear Commands | ||
- sonic-clear spanning_tree statistics | ||
- sonic-clear spanning_tree mst statistics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the 'mst' keyword here, it would be not in line with the MST instance specific clear command defined below. Please clarify if that's correct as per the intended design.
|
||
- debug spanning_tree dump global | ||
- debug spanning_tree dump mst global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the 'mst' keyword here, it would be not in line with the MST instance specific debug command defined below. Please clarify if that's correct as per the intended design.
``` | ||
admin@sonic: show spanning_tree detail | ||
admin@sonic: show spanning_tree mst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was done to be inline with this command header above. Please clarify if the 'mst' keyword needs to be removed at both the places and is as per the intended design.
Improved the MSTP documentation by adding new content, made few technical corrections as per MSTP standard and refined existing descriptions for better readability and grammatical accuracy.