Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add <img> tag for sonic logo #306

Merged
merged 1 commit into from
Dec 8, 2018
Merged

add <img> tag for sonic logo #306

merged 1 commit into from
Dec 8, 2018

Conversation

dmaltz
Copy link
Contributor

@dmaltz dmaltz commented Nov 30, 2018

add the sonic logo to the landing page. This commit depends on a previous pull request to add the sonic logo to the images directory. Let's approve and merge that one first, then we can mess with this one more.

@jleveque
Copy link
Contributor

@dmaltz: FYI, the other pull request you reference (to add the image file) was not created against the master branch of this (Azure) repo. It appears to be created against the master branch of your personal fork (dmaltz#1). Please either create a new pull request here, or simply add the image into this PR, as the two commits are very much related. Thanks!

@lguohan lguohan merged commit 277ebf2 into sonic-net:master Dec 8, 2018
@lguohan
Copy link
Contributor

lguohan commented Dec 8, 2018

@jleveque , I have cherry-picked that one. Now it is showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants