-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thermal control design #489
Conversation
Create thermal-control-design.md
Commands: | ||
fanstatus Show fan status information | ||
mlnx Mellanox platform specific configuration... | ||
psustatus Show PSU status information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psustatus may be enhanced to dump PSU FAN values as well..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psu fan should be covered by fan cli, not sure whether we want to add PSU fan info here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a modularity perspective, PSU FANs are added under PsuBase : so ideally, PSU FANs should be dumped as part of psustatus if at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jleveque what's your view on show PSU fan info as part of PSU show cli? Since we have a PSU daemon, if go this way we may consider to extend psud to get it's fan info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how it could be helpful to display PSU fan info along with status, voltage, etc. I think it is worth exploring extending the PSU daemon.
----- ------------- ---------------- --------------- ------------------------- ------------------------ ---------------- | ||
CPU 85 110 -10 120 -20 false | ||
ASIC 75 100 0 110 -10 false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For platforms which does thermal logic via BMC ( Ex monitor high/log and take action accordingly) in these cases do we need to display CLI's values or can we just show as N/A ?
@jleveque please review the feedback as well as the changes following to your request. |
Add a design doc for SONiC thermal control design.
Thermal control is intended to add a thermal control daemon to the system which will:
to keep the switch at the proper temperature by using cooling devices, e.g., fan.
Thermal control daemon needs to monitor the temperature of devices (CPU, ASIC, optical modules, etc) and the running status of fan. It stores temperature values fetched from sensors and the thermal device running status to the DB, to make these data available to CLI and SNMP or other apps which interested.