Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal control design #489

Merged
merged 10 commits into from
Dec 23, 2019
Merged

Thermal control design #489

merged 10 commits into from
Dec 23, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Oct 12, 2019

Add a design doc for SONiC thermal control design.
Thermal control is intended to add a thermal control daemon to the system which will:

  1. to keep the switch at the proper temperature by using cooling devices, e.g., fan.

  2. Thermal control daemon needs to monitor the temperature of devices (CPU, ASIC, optical modules, etc) and the running status of fan. It stores temperature values fetched from sensors and the thermal device running status to the DB, to make these data available to CLI and SNMP or other apps which interested.

Commands:
fanstatus Show fan status information
mlnx Mellanox platform specific configuration...
psustatus Show PSU status information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psustatus may be enhanced to dump PSU FAN values as well..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psu fan should be covered by fan cli, not sure whether we want to add PSU fan info here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a modularity perspective, PSU FANs are added under PsuBase : so ideally, PSU FANs should be dumped as part of psustatus if at all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleveque what's your view on show PSU fan info as part of PSU show cli? Since we have a PSU daemon, if go this way we may consider to extend psud to get it's fan info?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how it could be helpful to display PSU fan info along with status, voltage, etc. I think it is worth exploring extending the PSU daemon.

----- ------------- ---------------- --------------- ------------------------- ------------------------ ----------------
CPU 85 110 -10 120 -20 false
ASIC 75 100 0 110 -10 false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For platforms which does thermal logic via BMC ( Ex monitor high/log and take action accordingly) in these cases do we need to display CLI's values or can we just show as N/A ?

@liat-grozovik
Copy link
Collaborator

@jleveque please review the feedback as well as the changes following to your request.
If all is good we would like to merge this PR as code should be ready for review in the next few days.

@jleveque jleveque merged commit 178bb5a into sonic-net:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants