Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SONiC Reproduceable Build design doc #684

Merged
merged 9 commits into from
Oct 18, 2022
Merged

Conversation

xumia
Copy link
Contributor

@xumia xumia commented Oct 12, 2020

No description provided.

@baxia-lan
Copy link
Contributor

Searching on "make freeze" support, deb/py/web(sonic-net/sonic-buildimage#6255) and git(sonic-net/sonic-buildimage#6562) have been submitted, any plan to support the rest? Looks like the docker hook is the one missing now.

@xumia
Copy link
Contributor Author

xumia commented Mar 9, 2021

@baxia-lan , docker hook is in progress, we have already submitted a PR sonic-net/sonic-buildimage#5895, but it closed for conflict with another native dockerd PR sonic-net/sonic-buildimage#6086.

@xumia
Copy link
Contributor Author

xumia commented Oct 10, 2022

@qiluo-msft , can you please review again, thanks.

qiluo-msft
qiluo-msft previously approved these changes Oct 10, 2022
@xumia
Copy link
Contributor Author

xumia commented Oct 17, 2022

Converted to the file to Unix format.

@xumia
Copy link
Contributor Author

xumia commented Oct 17, 2022

@globaltrouble, could you please review again, thanks.

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check with other reviewers.

@xumia xumia merged commit 502cdf0 into sonic-net:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants