SONiC Generic Update and Rollback - HLD

[ghooo]

Repo	PR Title	State
sonic-utilities	[config][generic-update] Adding apply-patch, rollback, checkpoints commands
sonic-buildimage	[sonic-yang] Backlinks are none when there is 0 backlinks
sonic-utilities	[config][generic-update] Implementing patch sorting
sonic-buildimage	[yang-models] Removing sonic-acl import from sonic-nat.yang
sonic-utilities	[config][generic-update] Implementing patch sorting (2nd attempt)
sonic-utilities	[config][generic-update] Fix PatchApplier init order
sonic-utilities	[generic-config-updater] Cropping current/target config before sorting
sonic-utilities	[generic_config_updater] Logging
sonic-utilities	Generic_upater: Apply JSON change
sonic-utilities	generic_updater: Fix service validator related issues
sonic-utilities	[generic-config-updater] Adding logging to config-{replace, rollback, checkpoint, list-checkpoints}
sonic-mgmt	draft for dhcp server testcase
sonic-mgmt	Skip DUTs that don't support apply-patch feature
sonic-utilities	[generic-config-updater] Handling empty tables while sorting a patch
sonic-utilities	[generic-config-updater] Logging change just before applying it
sonic-utilities	generic_config_updater: Filename changed & VLAN validator added
sonic-mgmt	skip_release DUTs that don't support apply-patch feature
sonic-mgmt	Generic Config Updater cacl test
sonic-mgmt	Generic Config Updater Syslog server test
sonic-utilities	[generic-config-updater] Adding non-strict mode
sonic-buildimage	[yang-models] Validating 'services' exist if ACL type is 'CTRLPLANE'
sonic-buildimage	[yang-model] Using 'leafref' instead of 'must' for loopback
sonic-utilities	[generic-config-updater] Improving CreateOnly validator and marking /LOOPBACK_INTERFACE/LOOPBACK#/vrf_name as create-only
sonic-utilities	[GCU] Implementing DryRun by printing patch-sorter steps/imitating config_db
sonic-utilities	[GCU] Moving PatchSorter unit-test to json file to make it easier to read/maintain
sonic-mgmt	GCU loopback interface test
sonic-utilities	[GCU] Loading yang-models only once
sonic-mgmt	Make GCU syslog's test independent from previous test
sonic-mgmt	GCU vlan interface test
sonic-mgmt	GCU cacl test combination
sonic-utilities	[GCU] Different apply-patch runs should produce same sorted steps
sonic-utilities	[GCU] Copying config_db before calling sonic_yang.loadData
sonic-utilities	[GCU] Using simulated config instead of target config when validating replace operation in NoDependencyMoveValidator
sonic-mgmt	GCU portchannel interface test
sonic-buildimage	[sonic-yang-mgmt] Adding flag to disable/enable log printing
sonic-utilities	[GCU] Show default option for '--format'
sonic-utilities	[GCU] Disallowing DeleteInsteadOfReplaceMoveExtender from generating delete whole config move
sonic-utilities	[build-failure-fix][GCU] Sort referrer paths alphabetically directly on 202111
sonic-utilities	[generic-config-updater] Handle failed service restarts
sonic-utilities	[generic_config_updater] Minor update - No logical code change
sonic-mgmt	Add previous GCU tests to kvm daily test
sonic-utilities	[GCU] Mark children of bgp_neighbor as create-only
sonic-mgmt	GCU AAA test
sonic-mgmt	GCU test for BGPListener(BGPMonitor)
sonic-mgmt	Remove test reset check for GCU test
sonic-mgmt	Add incremental QOS config tests
sonic-mgmt	Skip GCU test on dut version that older than 202112
sonic-buildimage	[yang] Adding sonic-bgp-monitor to setup.py
sonic-buildimage	[yang] Fixing groupings when grouping is in the same module file
sonic-mgmt	Revert GCU cacl test due to random failure and add sleep in cacl for local test
sonic-mgmt	Added support of barefoot asic in incremental_qos test case
sonic-mgmt	Add pfcwd interval config tests
sonic-mgmt	[tests/generic_config_updater] Replace IP testcase for BGP Listener
sonic-mgmt	Incremental QOS config updater test update
sonic-mgmt	[generic-config-updater][Add/Remove rack] - Updated test to include add/remove rack via patch-apply
sonic-utilities	[GCU] Turning port admin down before some critical port changes
sonic-utilities	[GCU] Supporting Groupings during path-xpath translation
sonic-mgmt	[GCU] Add config ipv6 BGP neighbor test
sonic-mgmt	AddRack: Skip multi asic & remove hack
sonic-utilities	[GCU] Marking fields under BGP_PEER_RANGE, BGP_MONITORS as create-only
sonic-mgmt	GCU test for bgp speaker
sonic-mgmt	GCU test for BGP prefix
sonic-mgmt	[GCU] Add ethernet interface tests
sonic-utilities	[GCU] Marking fields under MIRROR_SESSION as create-only
sonic-utilities	[generic-config-updater] Add caclrule validator
sonic-mgmt	GCU test for Monitor Config
sonic-buildimage	[yang] In ACL_RULE PRIORITY is mandatory and also PACKET_ACTION for CTRLPLANE ACLs
sonic-mgmt	Add loganalyzer ignore regex for GCU
sonic-utilities	[GCU] Optimizing moves by adding generators for keys/tables
sonic-mgmt	[GCU] add ipv6, ethernet interface to kvm test suite
sonic-mgmt	[tests/generic_config_updater]skip test on release 202111
sonic-mgmt	[generic_config_updater]Add empty input fixture to verify configDB before GCU tests
sonic-mgmt	[generic_config_updater] add GCU ignore regex
sonic-utilities	[GCU] Supressing YANG errors from libyang while sorting
sonic-buildimage	[SY] Adding exceptlionList to validation exception
sonic-utilities	[GCU] Validate peer_group_range ip_range are correct
sonic-mgmt	Fix test case: generic_config_updater/test_ipv6.py::test_ipv6_neighbor_admin_change
sonic-utilities	[GCU] Handling non-compliant leaf-list with string values
sonic-mgmt	Fix test case: generic_config_updater/test_eth_interface.py::test_replace_mtu
sonic-utilities	[GCU] Handling type1 lists
sonic-mgmt	[configlet] Add test_add_rack to KVM daily test
sonic-mgmt	[tests/generic_config_updater] improve GCU portchannel test
sonic-utilities	[generic-config-updater] Add NTP validator
sonic-mgmt	[GCU] Shorten GCU ignored LA list
sonic-mgmt	[GCU] Add rollback validation test
sonic-mgmt	Avoid long run test in GCU.
sonic-mgmt	Bypass replace_lane to unblock submodule update
sonic-mgmt	Fix GCU update speed case to use supported speed get from the dut
sonic-utilities	[GCU] Moving UniqueLanes from only validating moves, to be a supplemental YANG validator

[praveen-li]

I will complete entire review today/

[praveen-li]

Overall looks good to me, let me know if there is a section for lower-level design and the section which describes the unit test in more detail.

[praveen-li]

Overall looks good to me, let me know if any pending questions, where my involvement is needed. Thx.