Add the SONiC FIPS configure introduction #997
Conversation
|
Could you add all the code PRs into this PR description? You may find example in #985 |
Updated, thanks. |
doc/fips/SONiC-OpenSSL-FIPS-140-3.md
Outdated
| @@ -163,6 +180,16 @@ ENABLE_FIPS ?= n | |||
| ``` | |||
| If the ENABLE_FIPS_FEATURE is not set, then the option ENABLE_FIPS is useless. | |||
|
|
|||
| ## SONiC FIPS Command lines | |||
| ### The command line to enable or disable FIPS | |||
| sonic-installer set-fips <image> [--enable-fips=[true|false]] | |||
There was a problem hiding this comment.
Is there a default value for --enable-fips? #Closed
There was a problem hiding this comment.
Changed to use --enable-fips/--disable-fips. The default value is to enable FIPS, if the option not specified.
|
@Staphylo Could you help review? |
| @@ -163,6 +180,20 @@ ENABLE_FIPS ?= n | |||
| ``` | |||
| If the ENABLE_FIPS_FEATURE is not set, then the option ENABLE_FIPS is useless. | |||
|
|
|||
| ## SONiC FIPS Command lines | |||
| ### The command line to enable or disable FIPS | |||
| sonic-installer set-fips <image> [--enable-fips|--disable-fips] | |||
There was a problem hiding this comment.
set-fips --enable-fips feels redundant compared to just set-fips --enable but this is just nitpicking.
If the plan is to have future knobs to this set-fips command then it's probably better to keep it the way you currently have it.
There was a problem hiding this comment.
@Staphylo , thanks for your comment.
The option --enable-fips can be skipped, the option --enable-fips is not necessary.
To enable it:
sonic-installer set-fips
To disable it:
sonic-installer set-fips --disable-fips
What I did Support to enable fips for the command sonic_installer See sonic-net/SONiC#997 How I did it sonic-installer set-fips [--enable-fips|--disable-fips] sonic-installer get-fips
What I did Cherry-pick #2154 Support to enable fips for the command sonic_installer See sonic-net/SONiC#997 How I did it sonic-installer set-fips [--enable-fips|--disable-fips] sonic-installer get-fips
What I did Support to enable fips for the command sonic_installer See sonic-net/SONiC#997 How I did it sonic-installer set-fips [--enable-fips|--disable-fips] sonic-installer get-fips
Add the SONiC FIPS configure introduction
PR: