Skip to content

Commit

Permalink
[voq] Neighbor entry impose encap index attribute deprecated (#2069)
Browse files Browse the repository at this point in the history
Since neighbor entry attribute SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX
is deprecated, and since the new version of SAI returns error, this
attribute is no longer sent the neighbor entry creation.

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
  • Loading branch information
vganesan-nokia authored Feb 2, 2022
1 parent d49eaa2 commit 05c2c2e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
4 changes: 0 additions & 4 deletions orchagent/neighorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1541,10 +1541,6 @@ bool NeighOrch::addVoqEncapIndex(string &alias, IpAddress &ip, vector<sai_attrib
attr.value.u32 = encap_index;
neighbor_attrs.push_back(attr);

attr.id = SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX;
attr.value.booldata = true;
neighbor_attrs.push_back(attr);

attr.id = SAI_NEIGHBOR_ENTRY_ATTR_IS_LOCAL;
attr.value.booldata = false;
neighbor_attrs.push_back(attr);
Expand Down
5 changes: 0 additions & 5 deletions tests/test_virtual_chassis.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,6 @@ def test_chassis_system_neigh(self, vct):
assert mac == test_neigh_mac, "Encap index of remote neigh mismatch with allocated encap index"

# Check for other mandatory attributes
# For remote neighbor, encap index must be imposed. So impose_index must be "true"
impose_index = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX")
assert impose_index != "", "Impose index attribute is not programmed for remote neigh in ASIC_DB"
assert impose_index == "true", "Impose index attribute is false for remote neigh"

# For remote neighbors, is_local must be "false"
is_local = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_IS_LOCAL")
assert is_local != "", "is_local attribute is not programmed for remote neigh in ASIC_DB"
Expand Down

0 comments on commit 05c2c2e

Please sign in to comment.