Install redis-tools in the base image

sonic-net · Dec 4, 2019 · 7e273d5 · 7e273d5
1 parent c4c0499
commit 7e273d5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 25 deletions.
diff --git a/dockers/docker-base-stretch/Dockerfile.j2 b/dockers/docker-base-stretch/Dockerfile.j2
@@ -47,7 +47,13 @@ RUN apt-get update &&        \
         vim-tiny             \
 # Install dependencies of supervisor
         python-pkg-resources \
-        python-meld3
+        python-meld3         \
+# dependencies of redis-tools
+        libatomic1           \
+        libjemalloc1         \
+        liblua5.1-0          \
+        lua-bitop            \
+        lua-cjson
 
 {% if CONFIGURED_ARCH == "armhf" %}
 # ip and ifconfig utility missing in docker for armhf

diff --git a/dockers/docker-orchagent/Dockerfile.j2 b/dockers/docker-orchagent/Dockerfile.j2
@@ -18,13 +18,6 @@ RUN apt-get update &&       \
         iproute2            \
         ndisc6              \
         tcpdump             \
-        # Install redis-tools dependencies
-        # TODO: implicitly install dependencies
-        libatomic1          \
-        libjemalloc1        \
-        liblua5.1-0         \
-        lua-bitop           \
-        lua-cjson           \
         libelf1             \
         libmnl0             \
         bridge-utils

diff --git a/dockers/docker-sonic-telemetry/Dockerfile.j2 b/dockers/docker-sonic-telemetry/Dockerfile.j2
@@ -11,14 +11,7 @@ RUN apt-get update      && \
     apt-get install -f -y  \
         libdbus-1-3        \
         libdaemon0         \
-        libjansson4        \
-        # Install redis-tools dependencies
-        # TODO: implicitly install dependencies
-        libatomic1          \
-        libjemalloc1        \
-        liblua5.1-0         \
-        lua-bitop           \
-        lua-cjson
+        libjansson4
 
 {% if docker_sonic_telemetry_debs.strip() -%}
 # Copy locally-built Debian package dependencies

diff --git a/dockers/docker-teamd/Dockerfile.j2 b/dockers/docker-teamd/Dockerfile.j2
@@ -12,14 +12,7 @@ RUN apt-get update      && \
         libdbus-1-3        \
         libdaemon0         \
         libjansson4        \
-        libpython2.7       \
-        # Install redis-tools dependencies
-        # TODO: implicitly install dependencies
-        libatomic1          \
-        libjemalloc1        \
-        liblua5.1-0         \
-        lua-bitop           \
-        lua-cjson
+        libpython2.7
 
 {% if docker_teamd_debs.strip() -%}
 # Copy locally-built Debian package dependencies

diff --git a/rules/docker-base-stretch.mk b/rules/docker-base-stretch.mk
@@ -2,7 +2,7 @@
 
 DOCKER_BASE_STRETCH = docker-base-stretch.gz
 $(DOCKER_BASE_STRETCH)_PATH = $(DOCKERS_PATH)/docker-base-stretch
-$(DOCKER_BASE_STRETCH)_DEPENDS += $(SUPERVISOR)
+$(DOCKER_BASE_STRETCH)_DEPENDS += $(SUPERVISOR) $(REDIS_TOOLS)
 $(DOCKER_BASE_STRETCH)_DEPENDS += $(SOCAT)
 
 GDB = gdb