[Dynamic buffer calc] Support dynamic buffer calculation (#6194)

**- Why I did it** To support dynamic buffer calculation. This PR also depends on the following PRs for sub modules - [sonic-swss: [buffermgr/bufferorch] Support dynamic buffer calculation #1338](sonic-net/sonic-swss#1338) - [sonic-swss-common: Dynamic buffer calculation #361](sonic-net/sonic-swss-common#361) - [sonic-utilities: Support dynamic buffer calculation #973](sonic-net/sonic-utilities#973) **- How I did it** 1. Introduce field `buffer_model` in `DEVICE_METADATA|localhost` to represent which buffer model is running in the system currently: - `dynamic` for the dynamic buffer calculation model - `traditional` for the traditional model in which the `pg_profile_lookup.ini` is used 2. Add the tables required for the feature: - ASIC_TABLE in platform/\<vendor\>/asic_table.j2 - PERIPHERAL_TABLE in platform/\<vendor\>/peripheral_table.j2 - PORT_PERIPHERAL_TABLE on a per-platform basis in device/\<vendor\>/\<platform\>/port_peripheral_config.j2 for each platform with gearbox installed. - DEFAULT_LOSSLESS_BUFFER_PARAMETER and LOSSLESS_TRAFFIC_PATTERN in files/build_templates/buffers_config.j2 - Add lossless PGs (3-4) for each port in files/build_templates/buffers_config.j2 3. Copy the newly introduced j2 files into the image and rendering them when the system starts 4. Update the CLI options for buffermgrd so that it can start with dynamic mode 5. Fetches the ASIC vendor name in orchagent: - fetch the vendor name when creates the docker and pass it as a docker environment variable - `buffermgrd` can use this passed-in variable 6. Clear buffer related tables from STATE_DB when swss docker starts 7. Update the src/sonic-config-engine/tests/sample_output/buffers-dell6100.json according to the buffer_config.j2 8. Remove buffer pool sizes for ingress pools and egress_lossy_pool Update the buffer settings for dynamic buffer calculation
sonic-net · Dec 13, 2020 · e010d83 · e010d83
1 parent 6db0124
commit e010d83
Show file tree

Hide file tree

Showing 59 changed files with 312 additions and 6 deletions.
diff --git a/device/mellanox/x86_64-mlnx_msn2010-r0/ACS-MSN2010/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2010-r0/ACS-MSN2010/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2100-r0/ACS-MSN2100/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2100-r0/ACS-MSN2100/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2410-r0/ACS-MSN2410/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2410-r0/ACS-MSN2410/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_defaults_t0.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_defaults_t1.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
@@ -0,0 +1,3 @@
+{%- set default_topo = 't0' %}
+{%- set dynamic_mode = 'true' %}
+{%- include 'buffers_config.j2' %}
diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-C28D8/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-C28D8/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_defaults_t0.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_defaults_t1.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_defaults_t0.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_defaults_t1.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn2740-r0/ACS-MSN2740/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn2740-r0/ACS-MSN2740/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3420-r0/ACS-MSN3420/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3420-r0/ACS-MSN3420/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_defaults_t0.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_defaults_t1.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3700-r0/ACS-MSN3700/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3700c-r0/ACS-MSN3700C/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3700c-r0/ACS-MSN3700C/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_defaults_t0.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_defaults_t1.j2
@@ -14,12 +14,16 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
  "ingress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossy_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -29,7 +33,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/ACS-MSN3800/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_defaults_t0.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_defaults_t1.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-C64/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_defaults_t0.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_defaults_t1.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_defaults_t1.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }

diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_dynamic.json.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D112C8/buffers_dynamic.json.j2
@@ -0,0 +1 @@
+../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers_dynamic.json.j2
diff --git a/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D24C52/buffers_defaults_t0.j2 b/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D24C52/buffers_defaults_t0.j2
@@ -13,7 +13,9 @@
 {%- macro generate_buffer_pool_and_profiles() %}
  "BUFFER_POOL": {
  "ingress_lossless_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ ingress_lossless_pool_size }}",
+ {%- endif %}
  "type": "ingress",
  "mode": "dynamic"
  },
@@ -23,7 +25,9 @@
  "mode": "dynamic"
  },
  "egress_lossy_pool": {
+ {%- if dynamic_mode is not defined %}
  "size": "{{ egress_lossy_pool_size }}",
+ {%- endif %}
  "type": "egress",
  "mode": "dynamic"
  }