Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstest]Remove config calls from test_mclag_cfg.py in swss vs tests #10245

Closed
dgsudharsan opened this issue Mar 16, 2022 · 4 comments
Closed
Assignees
Labels
Triaged this issue has been triaged

Comments

@dgsudharsan
Copy link
Collaborator

Description

As a part of ongoing effort to decouple vstests from sonic-utilities, the click commands called in vs tests should be modified to redis-CLI based config_db set.
This is to remove vs tests from running in sonic-utilities pipeline checkers

Example of existing command in test_mclag_cfg:
https://github.com/Azure/sonic-swss/blob/00266891a9f41e5bd37100b05237e865cde429b2/tests/test_mclag_cfg.py#L75

Example of how to migrate:
sonic-net/sonic-swss#2179

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@dgsudharsan
Copy link
Collaborator Author

@Praveen-Brcm @adyeung Can you please look into this?

@zhangyanzhao zhangyanzhao added Triaged this issue has been triaged Chassis 🤖 Modular chassis support labels Mar 30, 2022
@prsunny
Copy link
Contributor

prsunny commented Mar 30, 2022

@Praveen-Brcm , could you please address this? @gechiang for viz

@Praveen-Brcm
Copy link
Contributor

@prsunny, @gechiang , @dgsudharsan : Am working on the changes and will have them in by this week.

@adyeung
Copy link
Collaborator

adyeung commented May 11, 2022

Fix ready at sonic-net/sonic-swss#2264

@rlhui rlhui removed the Chassis 🤖 Modular chassis support label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

7 participants