Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the test file to remove click commands and do the REDIS-DB u… #2264

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

Praveen-Brcm
Copy link
Contributor

…pdates for MCLAG config commands.

What I did
Remove the CLICK commands in the test_mclag_cfg.py and use REDIS_DB for config updates.
Why I did it
To address #10245
How I verified it
VS tests.
Details if related

prsunny
prsunny previously approved these changes May 9, 2022
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Praveen-Brcm for addressing this.

dgsudharsan
dgsudharsan previously approved these changes May 11, 2022
@Praveen-Brcm Praveen-Brcm dismissed stale reviews from dgsudharsan and prsunny via 9589eae May 12, 2022 21:54
@Praveen-Brcm
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adyeung
Copy link

adyeung commented Aug 29, 2022

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@Praveen-Brcm
Copy link
Contributor Author

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2264 in repo sonic-net/sonic-swss

@Praveen-Brcm
Copy link
Contributor Author

/easycla

@Praveen-Brcm
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Praveen-Brcm
Copy link
Contributor Author

@dgsudharsan , @prsunny : Can you please help merge this change. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants