Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Yang for RADIUS_SERVER, RADIUS tables #12477

Closed
isabelmsft opened this issue Oct 24, 2022 · 1 comment · Fixed by #12749
Closed

Need Yang for RADIUS_SERVER, RADIUS tables #12477

isabelmsft opened this issue Oct 24, 2022 · 1 comment · Fixed by #12749
Labels
BRCM Help Wanted 🆘 Triaged this issue has been triaged YANG YANG model related changes

Comments

@isabelmsft
Copy link
Contributor

isabelmsft commented Oct 24, 2022 •
edited
Loading

Description

We don't have Yang models for RADIUS_SERVER, RADIUS tables.

Steps to reproduce the issue:

  1. Attempt to use GCU to apply-patch writing to RADIUS_SERVER or RADIUS tables
    Sample JSON patch:
    [{"op": "add", "path": "/RADIUS_SERVER", "value": {}}, {"op": "add", "path": "/RADIUS_SERVER/10.10.10.10", "value": {"auth_port": "1812", "priority": "1"}}]

Describe the results you received:

GCU patch application failed with error:
ValueError: Given patch is not valid because it has changes to tables without YANG models

Describe the results you expected:

GCU patch application success with successful write to ConfigDB

Output of show version:

admin@vlab-01:~$ show version

SONiC Software Version: SONiC.master.118843-40cbd3fe8
Distribution: Debian 11.3
Kernel: 5.10.0-12-2-amd64
Build commit: 40cbd3fe8
Build date: Wed Jul  6 14:46:15 UTC 2022
Built by: AzDevOps@sonic-build-workers-001QGK
@isabelmsft isabelmsft added the YANG YANG model related changes label Oct 24, 2022
@isabelmsft isabelmsft changed the title Need Yang for RADIUS_SERVER table Need Yang for RADIUS_SERVER, RADIUS tables Oct 24, 2022
@isabelmsft isabelmsft mentioned this issue Oct 24, 2022
Merged
@zhangyanzhao zhangyanzhao added Help Wanted 🆘 Triaged this issue has been triaged labels Oct 27, 2022
@zhangyanzhao
Copy link
Collaborator

@adyeung can you please help to check if BRCM can help to define YANG model for these tables?

@qiluo-msft qiluo-msft mentioned this issue Dec 23, 2022
Merged
7 tasks
qiluo-msft pushed a commit that referenced this issue Jan 12, 2023
@shdasari
SONiC YANG model for RADIUS. (#12749)
97161ae 
#### Why I did it
Added SONiC YANG model for RADIUS. 
Fixes #12477 

#### How I did it
Added the RADIUS and RADIUS_SERVER tables for global and per RADIUS server configuration. RADIUS statistics reside in COUNTERS_DB and are not part of the configuration. These are not a part of this PR.

#### How to verify it
Compiled sonic_yang_mgmt-1.0-py3-none-any.whl.

#### Description for the changelog
SONiC YANG model for RADIUS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BRCM Help Wanted 🆘 Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SONiC YANG model for RADIUS. shdasari/sonic-buildimage
2 participants
@zhangyanzhao @isabelmsft