Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigDB can get stuck in broken state if "config load_minigraph" crashes #1331

Closed
jleveque opened this issue Jan 22, 2018 · 1 comment
Closed

ConfigDB can get stuck in broken state if "config load_minigraph" crashes #1331

jleveque opened this issue Jan 22, 2018 · 1 comment
Labels
Bug 🐛

Comments

@jleveque
Copy link
Contributor

Description

If config load_minigraph crashes (e.g., due to an improperly formatted minigraph file), it can leave the ConfigDB in a broken state that requires manual intervention to recover from (i.e., database is completely empty; CONFIG_DB_INITIALIZED key is missing). ConfigDB should never be left in a broken state, even if config load_minigraph should crash.

For more context, see: sonic-net/SONiC#145

Steps to reproduce the issue:

  1. Modify /etc/minigraph.xml in order to create an improperly-formatted minigraph file (one that will cause the minigraph parser to crash)
  2. Run config load_minigraph, ensure it crashes while parsing (you will see Python backtrace)
  3. Check contents of ConfigDB (`redis-cli -n 4 keys '*'); DB will be empty.
@lguohan
Copy link
Collaborator

lguohan commented Oct 12, 2018

dup as #1629

@lguohan lguohan closed this as completed Oct 12, 2018
@Praveen-Brcm Praveen-Brcm mentioned this issue Apr 5, 2021
Merged
@Praveen-Brcm Praveen-Brcm mentioned this issue Aug 4, 2021
Merged
gechiang pushed a commit that referenced this issue Aug 5, 2021
@Praveen-Brcm
Updating sonic-swss submodule (#8340)
1bc3fdb 
Mclag enhacements support code changes. (#1331)
[crm] Fix for Issue #8036 (#1829)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
@Praveen-Brcm
Updating sonic-swss submodule (sonic-net#8340)
f1f4e43 
Mclag enhacements support code changes. (sonic-net#1331)
[crm] Fix for Issue sonic-net#8036 (sonic-net#1829)
judyjoseph added a commit that referenced this issue Aug 20, 2021
@judyjoseph
sonic-swss and sonic-utilities submodule update
1e81d10 
sonic-swss

e892dda Fix warmboot issue PR##8367 (#1866)
9c6023d Mclag enhacements support code changes. (#1331)

sonic-utilities

5465ea0 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual
3bac779  mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
@Praveen-Brcm @tapashdas
Mclag enhacements support code changes. (sonic-net#1331)
7aca82d 
* Mclag enhacements support code changes.
* Adding change to allow MCLAG remote MAC move.
* Added support for adding mclag remote mac to kernel, on top of PR-1276
* Updating the change from PR1276 and PR885.
* Adding new orchfiles to mock_tests
* MCLAG Unique IP support changes.
* Removed dependency with PR 885.
* Adding observer support for mlagorch.
* Fixed FDB notifiation issue
* Fixing the test_mclag_fdb type attributes.
* Remove as the change may not be supported on non-brcm for PortChannel settings.
* Removing the isolation group handling from Mlagorch, Isolation group now will be added/updated only via mclagsyncd updates.
* Added back the update function.

Co-authored-by: Tapash Das <tapash.das@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lguohan @jleveque