Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eventd] Eventd Unit test fails frequently #16996

Closed
dgsudharsan opened this issue Oct 25, 2023 · 6 comments
Closed

[Eventd] Eventd Unit test fails frequently #16996

dgsudharsan opened this issue Oct 25, 2023 · 6 comments
Assignees
@zbud-msft
Labels
MSFT Triaged this issue has been triaged

Comments

@dgsudharsan
Copy link
Collaborator

Description

Eventd unit tests are flaky and the build fails frequently. Attached are the list of build failures. One observation is frequency of failures increased after #16598

eventd_fail_log_1.txt
eventd_fail_log_2.txt
eventd_fail_log_3.txt
eventd_fail_log_4.txt

Steps to reproduce the issue:

  1. Build sonic.

Describe the results you received:

Eventd tests fail frequently

Describe the results you expected:

Eventd tests shouldn't fail

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@dgsudharsan dgsudharsan added MSFT Triaged this issue has been triaged labels Oct 25, 2023
@zbud-msft
Copy link
Contributor

ETA 11/3

@dgsudharsan dgsudharsan mentioned this issue Oct 31, 2023
Merged
11 tasks
lguohan pushed a commit that referenced this issue Oct 31, 2023
@dgsudharsan
[eventd]: Disabling eventd tests (#17053)
ca15c6f 
Disabling eventd unit tests until #16996 is addressed
@zbud-msft
Copy link
Contributor

zbud-msft commented Oct 31, 2023 •
edited
Loading

Fix in via #17055

@mssonicbld mssonicbld mentioned this issue Nov 1, 2023
Merged
11 tasks
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Nov 1, 2023
@dgsudharsan @mssonicbld
[eventd]: Disabling eventd tests (sonic-net#17053)
a9a00f8 
Disabling eventd unit tests until sonic-net#16996 is addressed
@liushilongbuaa
Copy link
Contributor

#17152
Hi @dgsudharsan , Maybe this PR can fix eventd.proxy. I'm not sure about my test environment.
Can you help review the code?

@dgsudharsan
Copy link
Collaborator Author

@liushilongbuaa There is also another PR raised by @zbud-msft . Can you both please co-ordinate? #17055

@liushilongbuaa
Copy link
Contributor

They are not the same issue.
I find that zmq_setsockopt need to be called before amq_connect according to doc. Maybe it is a code bug.
@zbud-msft try to fix from the UT scenario side. @zbud-msft can you help review PR#17152?

lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this issue Feb 6, 2024
@yaqiangz
Merged PR 9025464: Merge branch 'master' of https://github.com/Azure/…
acd8855 
…sonic-buildimage into internal

1. Resolve conflicts (introduced by this public PR: [sonic-net#16947](sonic-net#16947)) in `dockers/docker-dhcp-relay/Dockerfile.j2`:
```
<<<<<<< HEAD
RUN apt-get install -y dnsmasq gcc python3-dev

RUN pip3 install psutil

RUN apt-get purge -y gcc python3-dev
=======
{% if docker_dhcp_relay_whls.strip() %}
# Copy locally-built Python wheel dependencies
{{ copy_files("python-wheels/", docker_dhcp_relay_whls.split(' '), "/python-wheels/") }}

# Install locally-built Python wheel dependencies
{{ install_python_wheels(docker_dhcp_relay_whls.split(' ')) }}
{% endif %}
>>>>>>> 274d320
```

Accepted both changes, after resolved:
```
RUN apt-get install -y dnsmasq gcc python3-dev

RUN pip3 install psutil

RUN apt-get purge -y gcc python3-dev

{% if docker_dhcp_relay_whls.strip() %}
# Copy locally-built Python wheel dependencies
{{ copy_files("python-wheels/", docker_dhcp_relay_whls.split(' '), "/python-wheels/") }}

# Install locally-built Python wheel dependencies
{{ install_python_wheels(docker_dhcp_relay_whls.split(' ')) }}
{% endif %}
```

2. Because dnsmasq (used for ipv4 dhcp_server previously) exist in internal repo but not exist in public master repo, which would cause new added test case added by [sonic-net#16947](sonic-net#16947) in sonic-config-engine would fail. Also, we expect that dnsmasq is not running if "dhcp_server" feature is enabled.
So I **add support for new added test case** and **modify template to avoid run dnsmasq when dhcp_server feature is enabled** in below commit:
![image (2).png](https://dev.azure.com/msazure/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/git/repositories/8721f84d-7905-4f85-b5f1-0e19e8eac66b/pullRequests/9025464/attachments/image%20%282%29.png)

Related work items: sonic-net#350, sonic-net#803, sonic-net#2858, sonic-net#16945, sonic-net#16996, sonic-net#17047, sonic-net#17053, sonic-net#17056, sonic-net#17057, sonic-net#17068
@zbud-msft
Copy link
Contributor

zbud-msft commented Feb 15, 2024 •
edited
Loading

Fixed via #17055

vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this issue Nov 28, 2024
@dgsudharsan @vivekrnv
[eventd]: Disabling eventd tests (sonic-net#17053)
340df30 
Disabling eventd unit tests until sonic-net#16996 is addressed
@vivekrnv vivekrnv mentioned this issue Nov 28, 2024
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbud-msft zbud-msft

Labels
MSFT Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgsudharsan @liushilongbuaa @zbud-msft