Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202311] Celestica DX010 'show platform fan' fails #18767

Closed
mbze430 opened this issue Apr 23, 2024 · 6 comments
Closed

[202311] Celestica DX010 'show platform fan' fails #18767

mbze430 opened this issue Apr 23, 2024 · 6 comments
Labels
Issue for 202311 Triaged this issue has been triaged

Comments

@mbze430
Copy link

mbze430 commented Apr 23, 2024

brand new reload of 202311 build
SONiC Software Version: SONiC.202311.528790-c609af64d
SONiC OS Version: 11
Distribution: Debian 11.9
Kernel: 5.10.0-23-2-amd64
Build commit: c609af6
Build date: Mon Apr 22 12:07:23 UTC 2024
Built by: AzDevOps@vmss-soni003IGZ

Platform: x86_64-cel_seastone-r0
HwSKU: Seastone-DX010
ASIC: broadcom
ASIC Count: 1
Serial Number: DX010B2F108423LK100045
Model Number: R0872-F0010-01
Hardware Revision: N/A
Uptime: 20:40:27 up 8:51, 1 user, load average: 1.01, 1.06, 1.08
Date: Mon 22 Apr 2024 20:40:27

Docker images:
REPOSITORY TAG IMAGE ID SIZE
docker-gbsyncd-broncos 202311.528790-c609af64d be55fb422477 351MB
docker-gbsyncd-broncos latest be55fb422477 351MB
docker-gbsyncd-credo 202311.528790-c609af64d 713306b97976 324MB
docker-gbsyncd-credo latest 713306b97976 324MB
docker-syncd-brcm 202311.528790-c609af64d f3b99cf12dc4 715MB
docker-syncd-brcm latest f3b99cf12dc4 715MB
docker-macsec latest b37676abd39d 329MB
docker-dhcp-relay latest 068f197d5ecc 310MB
docker-orchagent 202311.528790-c609af64d 702e43f636f4 339MB
docker-orchagent latest 702e43f636f4 339MB
docker-fpm-frr 202311.528790-c609af64d 5bd2419e6b39 359MB
docker-fpm-frr latest 5bd2419e6b39 359MB
docker-nat 202311.528790-c609af64d 3443e92151e2 330MB
docker-nat latest 3443e92151e2 330MB
docker-sflow 202311.528790-c609af64d d943b74b78eb 328MB
docker-sflow latest d943b74b78eb 328MB
docker-eventd 202311.528790-c609af64d 9bd71979d03b 301MB
docker-eventd latest 9bd71979d03b 301MB
docker-teamd 202311.528790-c609af64d 64a4d7a505e4 327MB
docker-teamd latest 64a4d7a505e4 327MB
docker-platform-monitor 202311.528790-c609af64d 96826cb44a62 421MB
docker-platform-monitor latest 96826cb44a62 421MB
docker-snmp 202311.528790-c609af64d dc64cfffbc28 340MB
docker-snmp latest dc64cfffbc28 340MB
docker-router-advertiser 202311.528790-c609af64d b66f8434740e 301MB
docker-router-advertiser latest b66f8434740e 301MB
docker-lldp 202311.528790-c609af64d b09c9845f8d3 343MB
docker-lldp latest b09c9845f8d3 343MB
docker-mux 202311.528790-c609af64d 03e58e4a52e3 349MB
docker-mux latest 03e58e4a52e3 349MB
docker-sonic-gnmi 202311.528790-c609af64d f90899c4f877 389MB
docker-sonic-gnmi latest f90899c4f877 389MB
docker-database 202311.528790-c609af64d bc13e3a04fd0 301MB
docker-database latest bc13e3a04fd0 301MB
docker-sonic-mgmt-framework 202311.528790-c609af64d 12a5ea22d4f8 416MB
docker-sonic-mgmt-framework latest 12a5ea22d4f8 416MB

getting this error:

admin@sonic:~$ show platform fan
Traceback (most recent call last):
  File "/usr/local/bin/fanshow", line 85, in <module>
    fanShow.show()
  File "/usr/local/bin/fanshow", line 75, in show
    table.append((data_dict[DRAWER_FIELD_NAME], data_dict[LED_STATUS_FIELD_NAME], name, speed, data_dict[DIRECTION_FIELD_NAME], presence, status,
KeyError: 'drawer_name'
qnos added a commit to qnos/sonic-buildimage that referenced this issue Apr 24, 2024
@qnos
Seastone fix issue sonic-net#18767 psu fan speed issue
5d08361 
Why I did it
Fix issue sonic-net#18787 fan information could not been shown issue.

How I did it
Add psu fan get_target_speed api support.

How to verify it
Use `show platform fan` in branch 202311.
@qnos
Copy link
Contributor

qnos commented Apr 24, 2024

PR #18787 fix the issue.

@qnos qnos mentioned this issue Apr 24, 2024
Merged
12 tasks
@bingwang-ms bingwang-ms added Triaged this issue has been triaged Issue for 202311 labels Apr 24, 2024
@mbze430
Copy link
Author

mbze430 commented May 4, 2024

not sure how long it takes to get merged but as of 5/04/24 it is still not working

admin@sonic:~$ show ver

SONiC Software Version: SONiC.202311.537841-1d8111206
SONiC OS Version: 11
Distribution: Debian 11.9
Kernel: 5.10.0-23-2-amd64
Build commit: 1d81112
Build date: Fri May 3 12:22:51 UTC 2024
Built by: AzDevOps@vmss-soni003LFS

Platform: x86_64-cel_seastone-r0
HwSKU: Seastone-DX010
ASIC: broadcom
ASIC Count: 1
Serial Number: DX010B2F108423LK100045
Model Number: R0872-F0010-01
Hardware Revision: N/A
Uptime: 22:19:26 up 8:48, 1 user, load average: 1.19, 1.09, 1.08
Date: Sat 04 May 2024 22:19:26

qnos added a commit to qnos/sonic-buildimage that referenced this issue May 8, 2024
@qnos
Seastone fix issue sonic-net#18767 psu fan speed issue
a1824ba 
Why I did it
Fix issue sonic-net#18787 fan information could not been shown issue.

How I did it
Add psu fan get_target_speed api support.

How to verify it
Use `show platform fan` in branch 202311.
@lguohan lguohan pinned this issue May 12, 2024
@lguohan lguohan unpinned this issue May 12, 2024
lguohan pushed a commit that referenced this issue May 12, 2024
@qnos
[devices]: Seastone fix issue #18767 psu fan speed issue (#18787)
71eb9b9 
Fix issue #18787 fan information could not been shown issue.

How I did it
Add psu fan get_target_speed api support.

How to verify it
Use `show platform fan` in branch 202311.
@lguohan lguohan closed this as completed May 12, 2024
@mbze430
Copy link
Author

mbze430 commented May 13, 2024 •
edited
Loading

@lguohan
Even though this has been marked closed, but 'Semgrep' failed. should it be a concern?

@mbze430
Copy link
Author

mbze430 commented May 16, 2024

@qnos
according to this:
https://dev.azure.com/mssonic/build/_build/results?buildId=541868&view=results
it failed?

@qnos
Copy link
Contributor

qnos commented May 16, 2024

@qnos according to this: https://dev.azure.com/mssonic/build/_build/results?buildId=541868&view=results it failed?

It's not committed code issue, it was testbed timeout.
Another PR at similar date encountered the same issue.

@mbze430
Copy link
Author

mbze430 commented Jun 6, 2024 •
edited
Loading

@lguohan @qnos
as of 6/6/24 version SONiC.202311.564467-43bcca75f
this PR still have not been merged to 202311.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue for 202311 Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lguohan @mbze430 @bingwang-ms @qnos