Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP configuration no longer has iburst enabled by default #19425

Closed
saiarcot895 opened this issue Jun 28, 2024 · 1 comment · Fixed by #19424
Closed

NTP configuration no longer has iburst enabled by default #19425

saiarcot895 opened this issue Jun 28, 2024 · 1 comment · Fixed by #19424
Assignees
Labels
Triaged this issue has been triaged

Comments

@saiarcot895
Copy link
Contributor

Description

On 202305 and older images, NTP servers that were configured in config_db.json had iburst enabled by default. However, with #15058, because iburst was split into a separate configurable option (along with other options being added), and iburst needed to be enabled by default, the iburst option was removed from ntp.conf. While there's a way to restore this option when loading a config_db.json file, there's no easy way to do this when loading from minigraph (except for manually adding the option into the generated config_db.json file and either doing a config reload or restarting ntp-config and ntp services).

Steps to reproduce the issue:

  1. Load a 202311, 202405, or master branch image, and load a minigraph.xml file that has an NTP server specified. (The one generated from sonic-mgmt works for this purpose)

Describe the results you received:

In /etc/ntpsec/ntp.conf, on master branch (only the relevant lines pasted here):

server 10.0.0.1
restrict 10.0.0.1 kod limited nomodify noquery

server 10.0.0.2
restrict 10.0.0.2 kod limited nomodify noquery

Describe the results you expected:

The server lines above should have iburst at the end.

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

Relevant section of config_db.json:

    "NTP_SERVER": {
        "10.0.0.1": {},
        "10.0.0.2": {}
    },
@prgeor
Copy link
Contributor

prgeor commented Jul 3, 2024

@saiarcot895 seems you have the PR for enabling iburst. can you tag that in this issue

@yxieca yxieca closed this as completed in 990a725 Jul 11, 2024
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this issue Jul 26, 2024
…#19424)

Why I did it
In sonic-net#15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes sonic-net#19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this issue Jul 31, 2024
…#19424)

Why I did it
In sonic-net#15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes sonic-net#19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yxieca pushed a commit that referenced this issue Jul 31, 2024
…19741)

Why I did it
In #15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes #19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Jul 31, 2024
…#19424)

Why I did it
In sonic-net#15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes sonic-net#19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld pushed a commit that referenced this issue Jul 31, 2024
Why I did it
In #15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes #19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this issue Aug 1, 2024
…#19424)

Why I did it
In sonic-net#15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db.

Fixes sonic-net#19425.

How I did it
To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph.

How to verify it
Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants