Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect way to detect fast-reboot #2380

Closed
rameshsanth opened this issue Dec 13, 2018 · 1 comment
Closed

incorrect way to detect fast-reboot #2380

rameshsanth opened this issue Dec 13, 2018 · 1 comment
Assignees

Comments

@rameshsanth
Copy link

inconsistent strings used in /proc/cmdline to detect fast reboot.
dockers/docker-orchagent/swssconfig.sh uses "fast-reboot" to detect fast reboot

Looks like SONIC_BOOT_TYPE=fast is the string that is saved by sonic-utilities:scripts/fast-reboot file

Correct usage
docker_image_ctl.j2 checks for "SONIC_BOOT_TYPE=fast" in cmdline

@qiluo-msft
Copy link
Collaborator

The doc https://github.com/Azure/SONiC/blob/master/doc/warm-reboot/system-warmboot.md#details-of-kernel-arguments explain the design choice we made. Because of backward-compatibility issue, we made it inconsistent on purpose.

Let me know if you have more questions on the design doc.

stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Sep 21, 2022
87942836 [202205] Fix typo in platform_sfputil_helper.is_rj45_port (sonic-net#2374) (sonic-net#2380)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants