Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags 201811-1 seems to be rebased,it's commit id 602204f cannot be found in both master and 201811 branch #2492

Closed
TencentSwitchGroup opened this issue Jan 28, 2019 · 3 comments
Assignees

Comments

@TencentSwitchGroup
Copy link

Description

Cannot find commit 602204f (tags 201811-1) in both branch master and 201811. It seems there's a git rebase after the tag.

After compare log, I think the new commit id of tags 201811-1 should be 1e8d3ec.

Please release 201811-1 with the new commit id.

@yxieca
Copy link
Contributor

yxieca commented Jan 28, 2019

That is correct. There was an PR went into 201811 branch by mistake. And the change went later into master branch. Then cherry-picked again from master branch. In order to do so, the previous commit was discarded.

201811-01 was a work tag just so that I have a log for what was done before rebase. Please ignore this tag and use latest 201811 branch instead.

@xinliu-seattle
Copy link
Contributor

Ying will delete the tag which is a mistake, and close the issue.

@yxieca
Copy link
Contributor

yxieca commented Jan 31, 2019

The tag has been removed.

@yxieca yxieca closed this as completed Jan 31, 2019
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this issue Dec 6, 2022
Changes included:

```
28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message (sonic-net#2492)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
prsunny pushed a commit that referenced this issue Dec 6, 2022
Changes included:
```
28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message (#2492)
```
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this issue Dec 20, 2022
…c-net#2492)

In case of using dplane_fpm_nl zebra plugin we receive RTM_DELROUTE followed by RTM_NEWROUTE in a single FPM message when route attributes change (i.e nexthops change). Current implementation can only read the first one and ignores the rest.

What I did

I fixed FPM implementation to read multiple nl messages in a single FPM message.

Why I did it

Trying to move towards using dplane_fpm_nl.

How I verified it

UT and using dplane_fpm_nl zebra plugin.

Details if related
dprital added a commit to dprital/sonic-buildimage that referenced this issue Dec 28, 2022
Update sonic-swss submodule pointer to include the following:
* 782a2ef Align watermark flow with port configuration ([sonic-net#2525](sonic-net/sonic-swss#2525))
* dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([sonic-net#2521](sonic-net/sonic-swss#2521))
* 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([sonic-net#2492](sonic-net/sonic-swss#2492))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit that referenced this issue Dec 29, 2022
Update sonic-swss submodule pointer to include the following:
* 782a2ef Align watermark flow with port configuration ([#2525](sonic-net/sonic-swss#2525))
* dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([#2521](sonic-net/sonic-swss#2521))
* 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([#2492](sonic-net/sonic-swss#2492))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants