Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668

Closed
wangxin opened this issue Mar 14, 2019 · 2 comments
Closed

Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668

wangxin opened this issue Mar 14, 2019 · 2 comments

Comments

@wangxin
Copy link
Contributor

wangxin commented Mar 14, 2019

Description
If use CLI command "config vlan member add <interface_name>" to add an interface into a VLAN, the interface is always added as tagged.

Steps to reproduce the issue:

  1. Remove an interface from VLAN:
root@sonic:~$ show vlan brief
+-----------+----------------+------------+----------------+-----------------------+
|   VLAN ID | IP Address     | Ports      | Port Tagging   | DHCP Helper Address   |
+===========+================+============+================+=======================+
|      1000 | 192.168.0.1/21 | Ethernet4  | untagged       | 192.0.0.1             |
|           |                | Ethernet8  | untagged       | 192.0.0.2             |
|           |                | Ethernet12 | untagged       | 192.0.0.3             |
|           |                | Ethernet16 | untagged       | 192.0.0.4             |
|           |                | Ethernet20 | untagged       |                       |
|           |                | Ethernet24 | untagged       |                       |
|           |                | Ethernet28 | untagged       |                       |
|           |                | Ethernet32 | untagged       |                       |
|           |                | Ethernet36 | untagged       |                       |
|           |                | Ethernet40 | untagged       |                       |
|           |                | Ethernet44 | untagged       |                       |
|           |                | Ethernet48 | untagged       |                       |
|           |                | Ethernet52 | untagged       |                       |
|           |                | Ethernet56 | untagged       |                       |
|           |                | Ethernet60 | untagged       |                       |
|           |                | Ethernet64 | untagged       |                       |
|           |                | Ethernet68 | untagged       |                       |
|           |                | Ethernet72 | untagged       |                       |
|           |                | Ethernet76 | untagged       |                       |
|           |                | Ethernet80 | untagged       |                       |
|           |                | Ethernet84 | untagged       |                       |
|           |                | Ethernet88 | untagged       |                       |
|           |                | Ethernet92 | untagged       |                       |
|           |                | Ethernet96 | untagged       |                       |
+-----------+----------------+------------+----------------+-----------------------+
root@sonic:~# config vlan member del 1000 Ethernet4
root@sonic:~# show vlan brief
+-----------+----------------+------------+----------------+-----------------------+
|   VLAN ID | IP Address     | Ports      | Port Tagging   | DHCP Helper Address   |
+===========+================+============+================+=======================+
|      1000 | 192.168.0.1/21 | Ethernet8  | untagged       | 192.0.0.1             |
|           |                | Ethernet12 | untagged       | 192.0.0.2             |
|           |                | Ethernet16 | untagged       | 192.0.0.3             |
|           |                | Ethernet20 | untagged       | 192.0.0.4             |
|           |                | Ethernet24 | untagged       |                       |
|           |                | Ethernet28 | untagged       |                       |
|           |                | Ethernet32 | untagged       |                       |
|           |                | Ethernet36 | untagged       |                       |
|           |                | Ethernet40 | untagged       |                       |
|           |                | Ethernet44 | untagged       |                       |
|           |                | Ethernet48 | untagged       |                       |
|           |                | Ethernet52 | untagged       |                       |
|           |                | Ethernet56 | untagged       |                       |
|           |                | Ethernet60 | untagged       |                       |
|           |                | Ethernet64 | untagged       |                       |
|           |                | Ethernet68 | untagged       |                       |
|           |                | Ethernet72 | untagged       |                       |
|           |                | Ethernet76 | untagged       |                       |
|           |                | Ethernet80 | untagged       |                       |
|           |                | Ethernet84 | untagged       |                       |
|           |                | Ethernet88 | untagged       |                       |
|           |                | Ethernet92 | untagged       |                       |
|           |                | Ethernet96 | untagged       |                       |
+-----------+----------------+------------+----------------+-----------------------+
  1. Add the interface back into VLAN. The interface is added as tagged mode.
root@sonic:~# config vlan member add 1000 Ethernet4
root@sonic:~# show vlan brief
+-----------+----------------+------------+----------------+-----------------------+
|   VLAN ID | IP Address     | Ports      | Port Tagging   | DHCP Helper Address   |
+===========+================+============+================+=======================+
|      1000 | 192.168.0.1/21 | Ethernet4  | tagged         | 192.0.0.1             |
|           |                | Ethernet8  | untagged       | 192.0.0.2             |
|           |                | Ethernet12 | untagged       | 192.0.0.3             |
|           |                | Ethernet16 | untagged       | 192.0.0.4             |
|           |                | Ethernet20 | untagged       |                       |
|           |                | Ethernet24 | untagged       |                       |
|           |                | Ethernet28 | untagged       |                       |
|           |                | Ethernet32 | untagged       |                       |
|           |                | Ethernet36 | untagged       |                       |
|           |                | Ethernet40 | untagged       |                       |
|           |                | Ethernet44 | untagged       |                       |
|           |                | Ethernet48 | untagged       |                       |
|           |                | Ethernet52 | untagged       |                       |
|           |                | Ethernet56 | untagged       |                       |
|           |                | Ethernet60 | untagged       |                       |
|           |                | Ethernet64 | untagged       |                       |
|           |                | Ethernet68 | untagged       |                       |
|           |                | Ethernet72 | untagged       |                       |
|           |                | Ethernet76 | untagged       |                       |
|           |                | Ethernet80 | untagged       |                       |
|           |                | Ethernet84 | untagged       |                       |
|           |                | Ethernet88 | untagged       |                       |
|           |                | Ethernet92 | untagged       |                       |
|           |                | Ethernet96 | untagged       |                       |
+-----------+----------------+------------+----------------+-----------------------+

Describe the results you received:
Interface is always added into VLAN as tagged mode.

Describe the results you expected:
It would be better if I could choose the tagging mode while adding interface to VLAN.

Additional information you deem important (e.g. issue happens only occasionally):

Output of show version:

root@sonic:~# show ver
SONiC Software Version: SONiC.HEAD.912-11c2e9e
Distribution: Debian 9.8
Kernel: 4.9.0-8-2-amd64
Build commit: 11c2e9e
Build date: Wed Mar 13 00:42:43 UTC 2019
Built by: johnar@jenkins-worker-4

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-orchagent-mlnx      HEAD.912-11c2e9e    cc0c4b72cea5        287MB
docker-orchagent-mlnx      latest              cc0c4b72cea5        287MB
docker-syncd-mlnx          HEAD.912-11c2e9e    d7140ec96397        333MB
docker-syncd-mlnx          latest              d7140ec96397        333MB
docker-lldp-sv2            HEAD.912-11c2e9e    a51011331428        275MB
docker-lldp-sv2            latest              a51011331428        275MB
docker-dhcp-relay          HEAD.912-11c2e9e    6901afe82388        257MB
docker-dhcp-relay          latest              6901afe82388        257MB
docker-database            HEAD.912-11c2e9e    d38beeae108f        280MB
docker-database            latest              d38beeae108f        280MB
docker-snmp-sv2            HEAD.912-11c2e9e    6ce66e09752f        295MB
docker-snmp-sv2            latest              6ce66e09752f        295MB
docker-teamd               HEAD.912-11c2e9e    5c8054ac1e1d        275MB
docker-teamd               latest              5c8054ac1e1d        275MB
docker-sonic-telemetry     HEAD.912-11c2e9e    693501b07c48        300MB
docker-sonic-telemetry     latest              693501b07c48        300MB
docker-router-advertiser   HEAD.912-11c2e9e    57de786714ef        279MB
docker-router-advertiser   latest              57de786714ef        279MB
docker-platform-monitor    HEAD.912-11c2e9e    3ee47279a704        288MB
docker-platform-monitor    latest              3ee47279a704        288MB
docker-fpm-quagga          HEAD.912-11c2e9e    75366cc2b823        282MB
docker-fpm-quagga          latest              75366cc2b823        282MB
@justin-lu-lyc
Copy link

Hi wangxin
Use -u option to add interface with untagged mode
config vlan member add -u 1000 Ethernet4

@xinliu-seattle
Copy link
Contributor

please use -u to add untagged interface.

@yxieca yxieca mentioned this issue Mar 1, 2023
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Mar 1, 2023
@yxieca
[202205][utilities][swss-common][sairedis][platform-common][swss] adv…
42e7dfe 
…ance submodule head

utilities:
* a4f141f1 2023-01-10 | [sfputil] Firmware download/upgrade CLI support for QSFP-DD (sonic-net#1947) (sonic-net#2349) (HEAD -> 202205) [CliveNi]

swss-common:
* 41fcad8 2023-01-30 | Increase the netlink buffer size from 3MB to 16MB. (sonic-net#739) (HEAD -> 202205) [KISHORE KUNAL]

sairedis:
* 5ce9990 2023-02-27 | [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd (sonic-net#1201) (HEAD -> 202205) [Andriy Yurkiv]
* 3c2e0c5 2023-02-23 | Use new value of STATE_DB FAST_REBOOT entry (sonic-net#1196) [Aryeh Feigin]
* fe7756f 2023-02-28 | [submodule][SAI]Advance SAI head (sonic-net#1210) (github/202205) [Richard.Yu]

platform-common:
* 321a8e7 2022-09-23 | Cdb fw upgrade (sonic-net#308) (HEAD -> 202205) [CliveNi]

swss:
* ceea558 2023-02-28 | [orchagent]: Get bridge port ID from orchagent cache instead of SAI API (sonic-net#2657) (HEAD -> 202205) [Lawrence Lee]
* bd04e24 2023-03-01 | [dualtor] Fix neighbor miss when mux is not ready (sonic-net#2676) (HEAD -> 202205) [Longxiang Lyu]
* 7d87a90 2023-02-28 | [ci] Fix pipeline error about team5 not found. (sonic-net#2684) [Liu Shilong]
* 93a924c 2023-02-27 | [aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (sonic-net#2668) [Rajkumar-Marvell]
* 9d87ec4 2023-02-23 | swss: Fix Invalid port oid messages generated because of voq counters. (sonic-net#2653) [Sambath Kumar Balasubramanian]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this issue Mar 1, 2023
@yxieca
[202205][utilities][swss-common][sairedis][platform-common][swss] adv…
1f6456a 
…ance submodule head (#14029)

utilities:
* a4f141f1 2023-01-10 | [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947) (#2349) (HEAD -> 202205) [CliveNi]

swss-common:
* 41fcad8 2023-01-30 | Increase the netlink buffer size from 3MB to 16MB. (#739) (HEAD -> 202205) [KISHORE KUNAL]

sairedis:
* 5ce9990 2023-02-27 | [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd (#1201) (HEAD -> 202205) [Andriy Yurkiv]
* 3c2e0c5 2023-02-23 | Use new value of STATE_DB FAST_REBOOT entry (#1196) [Aryeh Feigin]
* fe7756f 2023-02-28 | [submodule][SAI]Advance SAI head (#1210) (github/202205) [Richard.Yu]

platform-common:
* 321a8e7 2022-09-23 | Cdb fw upgrade (#308) (HEAD -> 202205) [CliveNi]

swss:
* ceea558 2023-02-28 | [orchagent]: Get bridge port ID from orchagent cache instead of SAI API (#2657) (HEAD -> 202205) [Lawrence Lee]
* bd04e24 2023-03-01 | [dualtor] Fix neighbor miss when mux is not ready (#2676) (HEAD -> 202205) [Longxiang Lyu]
* 7d87a90 2023-02-28 | [ci] Fix pipeline error about team5 not found. (#2684) [Liu Shilong]
* 93a924c 2023-02-27 | [aclorch] Fixed issue #2204.Support IN_PORTS qualifer in MIRRORV6 table. (#2668) [Rajkumar-Marvell]
* 9d87ec4 2023-02-23 | swss: Fix Invalid port oid messages generated because of voq counters. (#2653) [Sambath Kumar Balasubramanian]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@vdahiya12 vdahiya12 mentioned this issue Mar 1, 2023
Merged
8 tasks
@StormLiangMS StormLiangMS mentioned this issue Mar 4, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this issue Mar 5, 2023
@StormLiangMS
[submodule advance] advance sonic-swss 309df59 #14076
ac14a3a 
Why I did it
submodule advance for master branch

309df59 - Revert "[aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 #2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668)" (Add warm/fast-boot feature processing for wedge100bf_32x/65x platforms #2687) (85 minutes ago) [StormLiangMS]
ebe8de7 - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch #2673) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
c9ae6aa - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common #2679) (2 days ago) [Junchao-Mellanox]
79afcb3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. #2646) (3 days ago) [Andriy Yurkiv]
c2b01ba - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module #2657) (3 days ago) [Lawrence Lee]
d8a1cb7 - [dualtor] Fix neighbor miss when mux is not ready ([mellanox] Fix in mlnx-ffb.sh #2676) (3 days ago) [Longxiang Lyu]
1531dff - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  #2684) (4 days ago) [Liu Shilong]
cfcd40c - [aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 #2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668) (4 days ago) [Rajkumar-Marvell]
35a7ab0 - swss: Fix Invalid port oid messages generated because of voq counters. (Failed to update FlexCounter, Segmentation fault #2653) (8 days ago) [Sambath Kumar Balasubramanian]
How I did it
How to verify it
run PR test
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Mar 6, 2023
@yxieca
[202205][swss] update submodule head
7530fb6 
swss:
* 143cd44 2023-03-04 | Revert "[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (sonic-net#2668)" (sonic-net#2687) (HEAD -> 202205, github/202205) [StormLiangMS]
* 25812f8 2023-02-06 | [test_mux] add sleep in test_NH (sonic-net#2648) [Nikola Dancejic]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this issue Mar 6, 2023
Merged
yxieca added a commit that referenced this issue Mar 7, 2023
@yxieca
[202205][swss] update submodule head (#14110)
5ac0bc3 
swss:
* 143cd44 2023-03-04 | Revert "[aclorch] Fixed issue #2204.Support IN_PORTS qualifer in MIRRORV6 table. (#2668)" (#2687) (HEAD -> 202205, github/202205) [StormLiangMS]
* 25812f8 2023-02-06 | [test_mux] add sleep in test_NH (#2648) [Nikola Dancejic]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this issue Mar 10, 2023
@StormLiangMS @xumia
[submodule advance] advance sonic-swss 309df59 sonic-net#14076
a18de71 
Why I did it
submodule advance for master branch

309df59 - Revert "[aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged sonic-net#2668)" (Add warm/fast-boot feature processing for wedge100bf_32x/65x platforms sonic-net#2687) (85 minutes ago) [StormLiangMS]
ebe8de7 - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch sonic-net#2673) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
c9ae6aa - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common sonic-net#2679) (2 days ago) [Junchao-Mellanox]
79afcb3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. sonic-net#2646) (3 days ago) [Andriy Yurkiv]
c2b01ba - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module sonic-net#2657) (3 days ago) [Lawrence Lee]
d8a1cb7 - [dualtor] Fix neighbor miss when mux is not ready ([mellanox] Fix in mlnx-ffb.sh sonic-net#2676) (3 days ago) [Longxiang Lyu]
1531dff - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  sonic-net#2684) (4 days ago) [Liu Shilong]
cfcd40c - [aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged sonic-net#2668) (4 days ago) [Rajkumar-Marvell]
35a7ab0 - swss: Fix Invalid port oid messages generated because of voq counters. (Failed to update FlexCounter, Segmentation fault sonic-net#2653) (8 days ago) [Sambath Kumar Balasubramanian]
How I did it
How to verify it
run PR test
qiluo-msft pushed a commit that referenced this issue Mar 20, 2023
@vdahiya12
[202012][sonic-platform-daemons][sonic-utilities] update submodule (#…
857d74d 
…14048)

For sonic-platform-daemons following commits are added to the submodule

dd8fbae (HEAD -> 202012, origin/202012) [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (#338)
846555e [thermalctld] fix some redundant removal of state DB tables (#315)
3d92fb9 Use github code scanning instead of LGTM (#316)

For sonic-utilities the following commits are added in this PR to the submodule
git log --oneline 39cdb49c..202012
ec4c6ea5 (HEAD -> 202012, origin/202012) [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (#2414) (#2704)
03ef272e [202012][vlan] Remove add field of vlanid to DHCP_RELAY table while adding vlan (#2681)
e00a81ac [202012][dhcp-relay] Add support for dhcp_relay config cli (#2640)
274184e1 [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (#2660) (#2668

#### Why I did it
updating the submodule of sonic-platform-daemons, sonic-utilities

#### How I did it

updated the submodule
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this issue Jun 14, 2023
@rajkumar38
[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIR…
cfcd40c 
…RORV6 table. (sonic-net#2668)

What I did
Fixed issue sonic-net#2204

Why I did it
Community test case "sonic-mgmt/tests/everflow/everflow/test_everflow_per_interface.py::test_everflow_per_interface[ipv6]"
fails for IPV6 traffic with below error.

Feb 15 09:06:44.205490 sonic ERR swss#orchagent: :- validateAclRuleMatch: Match SAI_ACL_ENTRY_ATTR_FIELD_IN_PORTS in rule RULE_1 is not supported by table EVERFLOWV6
Feb 15 09:06:44.206501 sonic ERR swss#orchagent: :- doAclRuleTask: Unknown or invalid rule attribute 'IN_PORTS : Ethernet2,Ethernet3,Ethernet8,Ethernet9'
Feb 15 09:06:44.207624 sonic ERR swss#orchagent: :- doAclRuleTask: Failed to create ACL rule. Rule configuration is invalid

How I verified it
Verify the Community Testcase with IPV6 traffic is passing.

Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this issue Jun 14, 2023
@StormLiangMS
Revert "[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualife…
309df59 
…r in MIRRORV6 table. (sonic-net#2668)" (sonic-net#2687)

Reverts sonic-net#2668

which cause ACL creation failure on Mellanox platform with below err msg.
2023-03-02T11:25:00.2743784Z E Mar 2 11:22:51.042274 str2-msn2700-spy-2 ERR syncd#SDK: [ACL.ERR] Failed calculating key blocks - too many keys selected.
2023-03-02T11:25:00.2744673Z E
2023-03-02T11:25:00.2745732Z E Mar 2 11:22:51.043026 str2-msn2700-spy-2 ERR swss#orchagent: :- create: create status: SAI_STATUS_FAILURE
2023-03-02T11:25:00.2746583Z E
2023-03-02T11:25:00.2747724Z E Mar 2 11:22:51.043196 str2-msn2700-spy-2 ERR swss#orchagent: :- addAclTable: Failed to create ACL table EVERFLOWV6
2023-03-02T11:25:00.2748625Z E
2023-03-02T11:25:00.2749932Z E Mar 2 11:22:51.043384 str2-msn2700-spy-2 ERR syncd#SDK: [SAI_ACL.ERR] mlnx_sai_acl.c[13937]- mlnx_create_acl_table: Failed to create flex key - Internal Error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wangxin @xinliu-seattle @justin-lu-lyc