Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping syncd process via syncd_request_shutdown --cold not working properly #3041

Closed
mfriyas opened this issue Jun 19, 2019 · 1 comment
Closed

Comments

@mfriyas
Copy link

mfriyas commented Jun 19, 2019

While executing restart_syncd.yml , the script was trying to execute the below command and expecting the process to be killed in output. But the command is fail to kill the syncd process.

utdown --cold264f-03:/home/admin# docker exec -i syncd /usr/bin/syncd_request_shu
requested COLD shutdown

root@sonic-z9264f-03:/home/admin# pgrep "<syncd>" -a

8396 /bin/bash /usr/local/bin/syncd.sh wait >>>>>>>>>>>>>>
8400 /bin/bash /usr/bin/syncd.sh wait

From script expectations

  • name: Stop syncd process
    shell: docker exec -i syncd /usr/bin/syncd_request_shutdown --cold

  • name: Wait 10 seconds for syncd to quit
    pause:
    seconds: 10

  • name: Look for syncd process
    shell: pgrep "<syncd>" -a
    register: syncd_out
    ignore_errors: yes

  • debug: msg="{{ syncd_out.stdout_lines }}"

  • fail: msg="Syncd is still running?"
    when:

    • ({{ syncd_out.stdout_lines | length }} > 0)
@yxieca
Copy link
Contributor

yxieca commented Sep 19, 2019

This issue has been addressed in master and 201811 branch.

@yxieca yxieca closed this as completed Sep 19, 2019
yxieca pushed a commit that referenced this issue Nov 30, 2023
* Update sonic-utilities to master branch version

sonic-utilities was (intentionally) pointing to a commit on a fork,
since merging sonic-utilities's changes for Bookworm first onto the
master branch would result in PR checker failures. Now that
sonic-buildimage is on master branch and the Bookworm changes in
sonic-utilities have been merged into master, sonic-utilties can now
point to master.

17e77fe2 Revert "Run yang validation in unit test (#3025)" (#3055)
96dd5559 [dhcp_relay] Fix dhcp_relay counter display issue (#3054)
6dfeee69 [sflow][db_migrator] Egress Sflow support (#3020)
02a588b7 Don't collect /proc/sched_debug
d7ec3251 Fix error about having a mutable default for field headers in dataclass
0ab3ab91 Fix test execution on Bookworm (#3041)
ef8f6f83 Specify test dependencies under extra_requires
61c44e80 Update python packages
1e813105 [wol] Implement wol command line utility (#3048)
8ebc56a0 [sonic_installer]: Improve exception handling: introduce notes. (#3029)
3610ce93 [sonic-package-manager] Fix YANG validation failure on upgrade when feature has constraints in YANG model on FEATURE table (#2933)
cfd2dd39 Add container rsyslog.conf to the sys dump (#3039)
c4b07828 Support new platform in generic configuration update (#3038)
a8d236c8 [fast-reboot-filter-routes.py] Remove click and improve error reporting (#3030)
75199c0f [sonic-package-manager] insert newline in /etc/sonic/generated_services.conf (#3040)
cd855698 [VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size (#2972)
f1e24ae5 GCU support for Cisco-8000 features (#3010)
67e1c3dc Update GCU rsyslog validator (#3012)
253b7975 [sonic-package-manager] do not modify config_db.json (#3032)
177dd8e8 [sonic-package-manager] add generated service to /etc/sonic/generated_services.conf (#3037)
62fcd77a Configure NTP according to extended configuration (#2835)
ced09404 [dualtor_neighbor_check] Adjust zero-mac check condition (#3034)
a4eeb698 [config] config reload should generate sysinfo if missing  (#3031)
e01fc891 Run yang validation in unit test (#3025)

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants