Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGP neighbor configurations are not pushed to frr when DEVICE_NEIGHBOR_METADATA is not present #4231

Closed
dgsudharsan opened this issue Mar 6, 2020 · 2 comments · Fixed by #4143
Closed

BGP neighbor configurations are not pushed to frr when DEVICE_NEIGHBOR_METADATA is not present #4231

dgsudharsan opened this issue Mar 6, 2020 · 2 comments · Fixed by #4143
Assignees
@pavel-shirshov

Comments

@dgsudharsan
Copy link
Collaborator

Description
When config_db.json does not have DEVICE_NEIGHBOR_METADATA, the BGP neighbor configurations present in config_db.json are not pushed to FRR.

The dependency on device_neighbor_metadata was introduced in this pull request
https://github.com/Azure/sonic-buildimage/pull/3694/files
Steps to reproduce the issue:

  1. Add BGP neighbor entries in config_db.json
  2. Do not add DEVICE_NEIGHBOR_METADATA
  3. Set docker_routing_config_mode as 'unified' or 'separated'

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@xinliu-seattle
Copy link
Contributor

Pavel, please confirm if this applies to 201911 or not.

@pavel-shirshov
Copy link
Contributor

Should be fixed by #4143

@pavel-shirshov pavel-shirshov mentioned this issue Apr 20, 2020
Merged
@lguohan lguohan linked a pull request Apr 21, 2020 that will close this issue
[bgpcfgd]: Split one bgp mega-template to chunks. #4143
Merged
lguohan pushed a commit that referenced this issue Apr 23, 2020
@pavel-shirshov
[bgpcfgd]: Split one bgp mega-template to chunks. (#4143)
057ced0 
The one big bgp configuration template was splitted into chunks.

Currently we have three types of bgp neighbor peers:

general bgp peers. They are represented by CONFIG_DB::BGP_NEIGHBOR table entries
dynamic bgp peers. They are represented by CONFIG_DB::BGP_PEER_RANGE table entries
monitors bgp peers. They are represented by CONFIG_DB::BGP_MONITORS table entries
This PR introduces three templates for each peer type:

bgp policies: represent policieas that will be applied to the bgp peer-group (ip prefix-lists, route-maps, etc)
bgp peer-group: represent bgp peer group which has common configuration for the bgp peer type and uses bgp routing policy from the previous item
bgp peer-group instance: represent bgp configuration, which will be used to instatiate a bgp peer-group for the bgp peer-type. Usually this one is simple, consist of the referral to the bgp peer-group, bgp peer description and bgp peer ip address.
This PR redefined constant.yml file. Now this file has a setting for to use or don't use bgp_neighbor metadata. This file has more parameters for now, which are not used. They will be used in the next iteration of bgpcfgd.

Currently all tests have been disabled. I'm going to create next PR with the tests right after this PR is merged.

I'm going to introduce better bgpcfgd in a short time. It will include support of dynamic changes for the templates.

FIX:: #4231
lguohan pushed a commit that referenced this issue Apr 25, 2020
@pavel-shirshov @lguohan
[bgpcfgd]: Split one bgp mega-template to chunks. (#4143)
2f44bcd 
The one big bgp configuration template was splitted into chunks.

Currently we have three types of bgp neighbor peers:

general bgp peers. They are represented by CONFIG_DB::BGP_NEIGHBOR table entries
dynamic bgp peers. They are represented by CONFIG_DB::BGP_PEER_RANGE table entries
monitors bgp peers. They are represented by CONFIG_DB::BGP_MONITORS table entries
This PR introduces three templates for each peer type:

bgp policies: represent policieas that will be applied to the bgp peer-group (ip prefix-lists, route-maps, etc)
bgp peer-group: represent bgp peer group which has common configuration for the bgp peer type and uses bgp routing policy from the previous item
bgp peer-group instance: represent bgp configuration, which will be used to instatiate a bgp peer-group for the bgp peer-type. Usually this one is simple, consist of the referral to the bgp peer-group, bgp peer description and bgp peer ip address.
This PR redefined constant.yml file. Now this file has a setting for to use or don't use bgp_neighbor metadata. This file has more parameters for now, which are not used. They will be used in the next iteration of bgpcfgd.

Currently all tests have been disabled. I'm going to create next PR with the tests right after this PR is merged.

I'm going to introduce better bgpcfgd in a short time. It will include support of dynamic changes for the templates.

FIX:: #4231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-shirshov pavel-shirshov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bgpcfgd]: Split one bgp mega-template to chunks. pavel-shirshov/sonic-buildimage
3 participants
@dgsudharsan @pavel-shirshov @xinliu-seattle