Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The order to apply qos.json and buffers.json cannot be reversed #446

Closed
stcheng opened this issue Mar 28, 2017 · 3 comments
Closed

The order to apply qos.json and buffers.json cannot be reversed #446

stcheng opened this issue Mar 28, 2017 · 3 comments
Labels
Bug 🐛

Comments

@stcheng
Copy link
Contributor

stcheng commented Mar 28, 2017

Currently there are internal dependencies in between qos.json and buffers.json files that if the order of applying the configurations cannot be guaranteed, some configurations cannot be applied correctly.

After brief debugging on this issue, it is possible that there might be some internal dependencies in bcmsai package.
@stcheng
Copy link
Contributor Author

stcheng commented Mar 28, 2017

#439 is a temporary fix and cannot guarantee to success.

@stcheng
Copy link
Contributor Author

stcheng commented Apr 16, 2017

@pavel-shirshov could you check if this is no longer an issue after the Broadcom SDK update.

@stcheng
Copy link
Contributor Author

stcheng commented Jun 7, 2017

no longer an issue.

@stcheng stcheng closed this as completed Jun 7, 2017
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this issue Sep 12, 2019
@jleveque
[reboot cause] Move reboot-cause files to /host directory so they per…
97ac8c7 
…sist across SONiC upgrades (sonic-net#446)
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@sihuihan88 @lguohan
[lua]: Only set the entry values when they are not nil (sonic-net#446)
e32212a 
* [lua]: Only set the entries when they are not nil

Signed-off-by: Sihui Han <sihan@microsoft.com>

* udpate

* further fix the detection time nil error

Signed-off-by: Sihui Han <sihan@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@andriymoroz-mlnx @lguohan
Crm tests (sonic-net#448)
5643178 
* update to SAI 1.2

* set LAG PORT_VLAN_ID instead of member port VLAN id

* [test]: Add test for the CRM feature

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [test]: Add test for the CRM feature

* Fix review comments

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* update to SAI 1.2

* set LAG PORT_VLAN_ID instead of member port VLAN id

* [test]: Add ACL test for the CRM feature

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* update to SAI 1.2

* set LAG PORT_VLAN_ID instead of member port VLAN id

* [test]: Add test for the CRM feature

* Use static neighbors instead of configuring server side
* Change polling interval value to 1 second
* Rename "nexthop_group_object" resource to "nexthop_group"

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [crmorch]: Implement CRM feature (sonic-net#447)

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [lua]: Only set the entry values when they are not nil (sonic-net#446)

* [lua]: Only set the entries when they are not nil

Signed-off-by: Sihui Han <sihan@microsoft.com>

* udpate

* further fix the detection time nil error

Signed-off-by: Sihui Han <sihan@microsoft.com>

* [test]: Add test for the CRM feature

* Fix fails in some test cases

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

* [test]: Add test for the CRM feature

* Fix fails in IPv6 test cases

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this issue Jan 17, 2021
@qiluo-msft
[sonic-swss-common] Update submodule
4b8a45e 
Includes commits:

```
2f79bb4 2021-01-16 | Fix ConfigDBPipeConnector.get_config() implementation (sonic-net#446) [Qi Luo]
fc64e3a 2021-01-12 | [dbconnector] protect db information with mutex (sonic-net#423) [Ying Xie]
e8a03de 2021-01-12 | [ci]: use sonicbld pool (sonic-net#445) [lguohan]
```
@tahmed-dev tahmed-dev mentioned this issue Jan 20, 2021
Merged
4 tasks
tahmed-dev added a commit to tahmed-dev/sonic-buildimage that referenced this issue Jan 20, 2021
@tahmed-dev
[sonic-swss-common]: Update Submodule
6291bf4 
Update in thie change:
640a218 [packaging]: Add Support For Libboost v1.71.0 (sonic-net#449)
2f79bb4 Fix ConfigDBPipeConnector.get_config() implementation (sonic-net#446)
fc64e3a [dbconnector] protect db information with mutex (sonic-net#423)
e8a03de [ci]: use sonicbld pool (sonic-net#445)

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stcheng