Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging] SSD health check print fast-reboot when warm-reboot is issued #5980

Closed
vaibhavhd opened this issue Nov 19, 2020 · 0 comments · Fixed by sonic-net/sonic-utilities#1254
Closed

[logging] SSD health check print fast-reboot when warm-reboot is issued #5980

vaibhavhd opened this issue Nov 19, 2020 · 0 comments · Fixed by sonic-net/sonic-utilities#1254
Assignees
@vaibhavhd
Labels
Master Branch Quality

Comments

@vaibhavhd
Copy link
Contributor

Description
During warm-reboot one of the logging incorrectly mentions fast-reboot

Steps to reproduce the issue:

  1. Issue warm-reboot -vv
  2. One of the step prints that fast-reboot is happening - Collecting logs to check ssd health before fast-reboot...

Describe the results you received:

admin@str-7260cx3-acs-7:~$ sudo warm-reboot -vvv
Thu 19 Nov 2020 08:23:46 PM UTC Pausing orchagent ...
Thu 19 Nov 2020 08:23:47 PM UTC Collecting logs to check ssd health before fast-reboot...
...
...
...
Thu 19 Nov 2020 08:24:12 PM UTC Stopped all remaining containers ...
Thu 19 Nov 2020 08:24:13 PM UTC Enabling Watchdog before warm-reboot

Describe the results you expected:

Logs should capture the reboot type from a variable, and not hard-code it.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

Latest of master.
@vaibhavhd vaibhavhd self-assigned this Nov 19, 2020
@vaibhavhd vaibhavhd mentioned this issue Nov 19, 2020
Merged
vaibhavhd added a commit to sonic-net/sonic-utilities that referenced this issue Nov 20, 2020
@vaibhavhd
Replace hard-coded fast-reboot with variable. And some typo correctio…
05c8e33 
…ns (#1254)

Cosmetic fix: One of the logging statements during warm-reboot incorrectly prints fast-reboot.
Fixes sonic-net/sonic-buildimage#5980

Fix: Remove hard-coded fast-reboot with REBOOT_TYPE variable.
      Additionally, corrected a few typos found in the comments.
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
@malletvapid23
Replace hard-coded fast-reboot with variable. And some typo correctio…
b2c3fd6 
…ns (#1254)

Cosmetic fix: One of the logging statements during warm-reboot incorrectly prints fast-reboot.
Fixes sonic-net/sonic-buildimage#5980

Fix: Remove hard-coded fast-reboot with REBOOT_TYPE variable.
      Additionally, corrected a few typos found in the comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibhavhd vaibhavhd

Labels
Master Branch Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cosmetic fix - replace hard-coded fast-reboot with REBOOT_TYPE variable vaibhavhd/sonic-utilities
1 participant
@vaibhavhd