[Build]: Fix the bin image generated from raw image issue #10083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
added
Bug 🐛
Request for 201911 Branch 
Request for 202006 Branch
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
FuzailBrcm
approved these changes
Feb 25, 2022
|
@Kalimuthu-Velappan |
xumia
changed the title
liushilongbuaa
approved these changes
Feb 25, 2022
| mkdir -p `dirname $OUTPUT_RAW_IMAGE` | ||
| sudo rm -f $OUTPUT_RAW_IMAGE | ||
|
|
||
| generate_device_list "./installer/$TARGET_PLATFORM/platforms_asic" | ||
|
|
||
| generate_onie_installer_image | ||
| generate_onie_installer_image "$tmp_output_onie_image" |
There was a problem hiding this comment.
It seems good also applying to kvm.
|
/azpw run |
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
judyjoseph
pushed a commit
that referenced
this pull request
Mar 20, 2022
Why I did it It is to fix the issue #10048 When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Feb 6, 2023
…10083) Why I did it It is to fix the issue sonic-net#10048 When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
8 tasks
|
Cherry pick PR created: #13672 |
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 9, 2023
…13672) #### Why I did it Cherry pick from #10083 It is to fix the issue #10048 When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one. #### How I did it Rename the intermediate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
How I did it
Rename the intermediate file.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)