Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Makefile]: Fix unmatched variable name ENABLE_SYNCD_RPC #1032

Merged
merged 1 commit into from
Oct 12, 2017
Merged

[Makefile]: Fix unmatched variable name ENABLE_SYNCD_RPC #1032

merged 1 commit into from
Oct 12, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Oct 11, 2017

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

That's the correct output:

│➜  build git:(internal) ✗ make ENABLE_SYNCD_RPC=y target/docker-syncd-brcm-rpc.gz
│SONiC Build System
│
│Build Configuration
│"CONFIGURED_PLATFORM"             : "broadcom"
│"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
│"SONIC_CONFIG_BUILD_JOBS"         : "1"
│"SONIC_CONFIG_MAKE_JOBS"          : "4"
│"DEFAULT_USERNAME"                : "admin"
│"DEFAULT_PASSWORD"                : "YourPaSsWoRd"
│"ENABLE_DHCP_GRAPH_SERVICE"       : ""
│"SHUTDOWN_BGP_ON_START"           : ""
│"SONIC_CONFIG_DEBUG"              : ""
│"ROUTING_STACK"                   : "quagga"
│"ENABLE_SYNCD_RPC"                : "y"
│"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"

jleveque
jleveque previously approved these changes Oct 11, 2017
View reviewed changes
jleveque
jleveque reviewed Oct 11, 2017
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about these lines?

https://github.com/Azure/sonic-buildimage/blob/master/slave.mk#L62

@jleveque jleveque dismissed their stale review October 11, 2017 21:35

Added comment

@stcheng
Copy link
Contributor Author

stcheng commented Oct 11, 2017

@jleveque interesting. these lines are just not working as expected. I'll check.

[Makefile]: Fix unmatched variable name ENABLE_SYNCD_RPC
7b7c217 
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng
Copy link
Contributor Author

stcheng commented Oct 11, 2017

@jleveque I've removed related codes

jleveque
jleveque approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cleaner and much less confusing than having both ENABLE_SYNCD_RPC and SONIC_ENABLE_SYNCD_RPC variables.

@stcheng stcheng merged commit 27cac94 into sonic-net:master Oct 12, 2017
@stcheng stcheng deleted the syncd_rpc branch October 12, 2017 00:46
stcheng pushed a commit that referenced this pull request Oct 13, 2017
Revert "[Makefile]: Fix unmatched variable name ENABLE_SYNCD_RPC (#1032…
9317431 
…)"

This reverts commit 27cac94.
@marian-pritsak marian-pritsak mentioned this pull request Dec 5, 2017
Closed
lguohan pushed a commit that referenced this pull request Jun 4, 2022
@bingwang-ms
[sonic-sairedis]: update submodule sonic-sairedis (#10982)
eda95b8 
544e4c2 (origin/202012) [ci] Paralize azure pipeline (#1044)
45b310d Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (#1016)
9e56674 Advance submodule SAI for 202012 branch (#1032)

Signed-off-by: bingwang <wang.bing@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stcheng @jleveque @qiluo-msft