[Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation #10320

ayurkiv-nvda · 2022-03-22T16:01:59Z

Why I did it

Need to implement read_eeprom/write_eeprom API for Credo Y-cable for Dual-Tor

How I did it

Used mlxreg utility for API implementation

How to verify it

run sfp unit tests

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

lgtm-com · 2022-03-22T18:12:22Z

This pull request introduces 1 alert when merging 2e9887e6f3263c87a7d754c27380ba0979f4bc6d into f8e1104 - view on LGTM.com

new alerts:

1 for Unused local variable

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

nazariig · 2022-03-23T19:29:32Z

@ayurkiv-nvda please fix the build:

==================================== ERRORS ====================================
______________________ ERROR collecting tests/test_sfp.py ______________________
ImportError while importing test module '/sonic/platform/mellanox/mlnx-platform-api/tests/test_sfp.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python2.7/dist-packages/_pytest/python.py:450: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:668: in pyimport
    __import__(modname)
/usr/lib/python2.7/dist-packages/_pytest/assertion/rewrite.py:294: in load_module
    six.exec_(co, mod.__dict__)
/usr/lib/python2.7/dist-packages/six.py:709: in exec_
    exec("""exec _code_ in _globs_, _locs_""")
<string>:1: in <module>
    ???
tests/test_sfp.py:31: in <module>
    from .input_platform import output_sfp
E   ImportError: No module named input_platform

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

ayurkiv-nvda · 2022-03-25T12:07:59Z

@ayurkiv-nvda please fix the build:

==================================== ERRORS ====================================
______________________ ERROR collecting tests/test_sfp.py ______________________
ImportError while importing test module '/sonic/platform/mellanox/mlnx-platform-api/tests/test_sfp.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python2.7/dist-packages/_pytest/python.py:450: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:668: in pyimport
    __import__(modname)
/usr/lib/python2.7/dist-packages/_pytest/assertion/rewrite.py:294: in load_module
    six.exec_(co, mod.__dict__)
/usr/lib/python2.7/dist-packages/six.py:709: in exec_
    exec("""exec _code_ in _globs_, _locs_""")
<string>:1: in <module>
    ???
tests/test_sfp.py:31: in <module>
    from .input_platform import output_sfp
E   ImportError: No module named input_platform

Done

…entation Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

ayurkiv-nvda · 2022-03-30T08:14:58Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-03-30T08:14:59Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-03-30T08:15:11Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2022-03-30T08:15:55Z

/AzurePipelines run Azure.sonic-buildimage (Test kvmtest-t0)

azure-pipelines · 2022-03-30T08:16:00Z

No pipelines are associated with this pull request.

oleksandrivantsiv · 2022-03-30T11:51:00Z

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

@@ -222,7 +305,11 @@ def get_presence(self):
        return eeprom_raw is not None

    # Read out any bytes from any offset
-    def read_eeprom(self, offset, num_bytes):
+    def _read_eeprom_specific_bytes(self, offset, num_bytes):


Not critical, but I suggest renaming this function to _read_eeprom_sfp_bytes or a name you choose that tells what function is actually doing.

ayurkiv-nvda requested a review from lguohan as a code owner March 22, 2022 16:02

ayurkiv-nvda force-pushed the credo_y_cable_azure branch from 4c58bec to 2e9887e Compare March 22, 2022 17:35

nazariig reviewed Mar 22, 2022

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py Outdated Show resolved Hide resolved

nazariig reviewed Mar 22, 2022

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py Outdated Show resolved Hide resolved

ayurkiv-nvda force-pushed the credo_y_cable_azure branch 4 times, most recently from 3fa09c2 to ec5af34 Compare March 23, 2022 18:52

nazariig previously approved these changes Mar 23, 2022

View reviewed changes

nazariig added Platform: Mellanox Enhancement ➕ labels Mar 23, 2022

ayurkiv-nvda dismissed nazariig’s stale review via 7d875aa March 24, 2022 11:06

ayurkiv-nvda force-pushed the credo_y_cable_azure branch from ec5af34 to 7d875aa Compare March 24, 2022 11:06

nazariig previously approved these changes Mar 24, 2022

View reviewed changes

nazariig requested review from liat-grozovik and volodymyrsamotiy March 24, 2022 11:15

liat-grozovik changed the title ~~Credo Y-cable read_eeprom/write_eeprom API implementation~~ [Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation Mar 24, 2022

oleksandrivantsiv reviewed Mar 24, 2022

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py Show resolved Hide resolved

keboliu reviewed Mar 24, 2022

View reviewed changes

ayurkiv-nvda dismissed nazariig’s stale review via 895484f March 25, 2022 12:12

ayurkiv-nvda requested review from qiluo-msft and xumia as code owners March 28, 2022 12:35

ayurkiv-nvda force-pushed the credo_y_cable_azure branch from 6350113 to 895484f Compare March 28, 2022 12:39

ayurkiv-nvda added 2 commits March 28, 2022 12:46

[mlnx-platform-api] Credo Y-cable read_eeprom/write_eeprom API implem…

5abf030

…entation Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

Y-cable fixes

b0fc8b2

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

ayurkiv-nvda force-pushed the credo_y_cable_azure branch from 895484f to b0fc8b2 Compare March 28, 2022 13:48

nazariig approved these changes Mar 29, 2022

View reviewed changes

keboliu approved these changes Mar 30, 2022

View reviewed changes

oleksandrivantsiv reviewed Mar 30, 2022

View reviewed changes

oleksandrivantsiv approved these changes Mar 30, 2022

View reviewed changes

liat-grozovik approved these changes Mar 30, 2022

View reviewed changes

liat-grozovik merged commit 1e2e493 into sonic-net:master Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation #10320

[Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation #10320

ayurkiv-nvda commented Mar 22, 2022 •

edited

Loading

lgtm-com bot commented Mar 22, 2022

nazariig commented Mar 23, 2022

ayurkiv-nvda commented Mar 25, 2022

ayurkiv-nvda commented Mar 30, 2022

mssonicbld commented Mar 30, 2022

azure-pipelines bot commented Mar 30, 2022

mssonicbld commented Mar 30, 2022

azure-pipelines bot commented Mar 30, 2022

oleksandrivantsiv Mar 30, 2022

[Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation #10320

[Mellanox] Credo Y-cable read_eeprom/write_eeprom API implementation #10320

Conversation

ayurkiv-nvda commented Mar 22, 2022 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

lgtm-com bot commented Mar 22, 2022

nazariig commented Mar 23, 2022

ayurkiv-nvda commented Mar 25, 2022

ayurkiv-nvda commented Mar 30, 2022

mssonicbld commented Mar 30, 2022

azure-pipelines bot commented Mar 30, 2022

mssonicbld commented Mar 30, 2022

azure-pipelines bot commented Mar 30, 2022

oleksandrivantsiv Mar 30, 2022

Choose a reason for hiding this comment

ayurkiv-nvda commented Mar 22, 2022 •

edited

Loading