[minigraph] change device type #10396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the minigraph parser, if encounter MgmtTsToR, change to MgmtTsToRRouter Signed-off-by: Xichen Lin <xichenlin@microsoft.com>
prsunny
approved these changes
Mar 30, 2022
|
Should we close this PR? @Xichen96 |
|
Close this PR since we will use feature flag in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the minigraph parser, if encounter MgmtTsToR, change to
MgmtTsToRRouter
Signed-off-by: Xichen Lin xichenlin@microsoft.com
Why I did it
Starting radvd container depends on the device type ending in ToRRouter, which MgmtTsToR is but does not end with. Modifying the name allows the MgmtTsToR to be treated like a ToRRouter.
How I did it
Change name from MgmtTsToR to MgmtTsToRRouter
How to verify it
unit test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)