[dhcp_relay] Add "vlan missing ip helper" dhcp relay unittest #10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Jun 3, 2022
kellyyeh
added a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
Aug 24, 2022
7 tasks
kellyyeh
added a commit
that referenced
this pull request
Aug 25, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 9, 2022
kellyyeh
added
the
Request for 202111 Branch
richardyu-ms
pushed a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Some vlans could have missing ip/ipv6 helpers. Adding unit test to ensure expected processes run in dhcp_relay docker
How I did it
How to verify it
Build sonic_config_engine python wheel. Run dhcp_relay docker with expected docker supervisord file
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)