[Arista]: Fix the udev waiting in networking start #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to fix the issue in aristanetworks/sonic#16 For the checking condition used, it is only applied to Arista switches Signed-off-by: Boyang Yu <byu@arista.com>
|
I took this change and compiled but showing a permission denied issue while building "aboot" image in my VM. Just want to ensure this doesn't happen in release build. Logs:
|
Signed-off-by: Boyang Yu <byu@arista.com>
|
Changes looks good. I compiled it in my local repo and tested on A7060. eth0 is coming up as soon as logged in. |
prsunny
approved these changes
Oct 30, 2017
lguohan
approved these changes
Oct 31, 2017
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Nov 19, 2019
sairedis: * [SAI] Update SAI submodule to v1.5.1 (sonic-net#532) * Cleanup Makefile.am from BFN specific code (sonic-net#530) * [vs] Implement indices for debug counters in VS (sonic-net#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529) * [flex_counter] Add sairedis support for drop counters (sonic-net#520) swss: * [orchagent] Add swss support for drop counters (sonic-net#1075) * [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129) * [utilities] Create utility classes for interacting with flex counters (sonic-net#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809) * Fix traceroute issue (sonic-net#1113) utilities: * Add CLI support for configurable drop counters (sonic-net#688) * Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741) * SONiC Management Framework Release 1.0 (sonic-net#659) Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Nov 21, 2019
sairedis: * [SAI] Update SAI submodule to v1.5.1 (#532) * Cleanup Makefile.am from BFN specific code (#530) * [vs] Implement indices for debug counters in VS (#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (#529) * [flex_counter] Add sairedis support for drop counters (#520) swss: * [orchagent] Add swss support for drop counters (#1075) * [orchagent] warning fixes for 32bit arch compilation (#1129) * [utilities] Create utility classes for interacting with flex counters (#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (#809) * Fix traceroute issue (#1113) utilities: * Add CLI support for configurable drop counters (#688) * Revert "SONiC Management Framework Release 1.0 (#659)" (#741) * SONiC Management Framework Release 1.0 (#659) Signed-off-by: Danny Allen <daall@microsoft.com>
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
sairedis: * [SAI] Update SAI submodule to v1.5.1 (sonic-net#532) * Cleanup Makefile.am from BFN specific code (sonic-net#530) * [vs] Implement indices for debug counters in VS (sonic-net#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529) * [flex_counter] Add sairedis support for drop counters (sonic-net#520) swss: * [orchagent] Add swss support for drop counters (sonic-net#1075) * [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129) * [utilities] Create utility classes for interacting with flex counters (sonic-net#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809) * Fix traceroute issue (sonic-net#1113) utilities: * Add CLI support for configurable drop counters (sonic-net#688) * Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741) * SONiC Management Framework Release 1.0 (sonic-net#659) Signed-off-by: Danny Allen <daall@microsoft.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…sonic-net#1093) * [utilities] Create utility classes for interacting with flex counters - Adds utility classes for interacting with flex counters - Updates makefiles to support new utilities Signed-off-by: Danny Allen <daall@microsoft.com> * Reorganize helper classes * Respond to PR feedback * Fix stray includes * Strip comma from end of string instead of beginning * Fix build issue * Fix style issues * Add workaround for flex counter behavior
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Jul 27, 2022
Upgrade submodule sairedis to take the fix for saithrift build Upgrade SAI to latest for building in bullseye (sonic-net#1093) involve other changes in sairedis: [sairedis] Fix reopen recoding file (sonic-net#1087) Update PN with XPN support (sonic-net#1081) [syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048) Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
7 tasks
lguohan
pushed a commit
that referenced
this pull request
Jul 28, 2022
Upgrade submodule sairedis to take the fix for saithrift build Upgrade SAI to latest for building in bullseye (#1093) involve other changes in sairedis: [sairedis] Fix reopen recoding file (#1087) Update PN with XPN support (#1081) [syncd] Remove error message when tryTranslateVidToRid fails (#1048) Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Sep 23, 2022
[submodule]: update sairedis (sonic-net#11545) Upgrade submodule sairedis to take the fix for saithrift build Upgrade SAI to latest for building in bullseye (sonic-net#1093) involve other changes in sairedis: [sairedis] Fix reopen recoding file (sonic-net#1087) Update PN with XPN support (sonic-net#1081) [syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048) Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix the issue in aristanetworks/sonic#16
We noticed that the long waiting time in service networking start is because the original 'udevadm settle' waits for some irrelevant devices. By the change, only eth0 is waited for.
For the checking condition used, this change is only applied to Arista switches
Signed-off-by: Boyang Yu byu@arista.com