Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-gnmi] Support GNMI native write #10948

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented May 27, 2022

Signed-off-by: Gang Lv ganglv@microsoft.com

Why I did it

Provide GNMI native write interface for configuration.

How I did it

Add configuration parameters for GNMI native write.

How to verify it

Check build pipeline.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Provide GNMI native write interface for configuration.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@@ -0,0 +1,10 @@
build/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create new repo sonic-gmni under sonic-net org and use submodule approach.

@ganglyu
Copy link
Contributor Author

ganglyu commented Jun 3, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhangyanzhao
Copy link
Collaborator

@qiluo-msft would you please review and approve this PR?
@ganglyu please fix the build conflict.

@ganglyu ganglyu changed the title [sonic-gnmi] Create GNMI server [sonic-gnmi] Support GNMI native write Nov 29, 2022
@ganglyu ganglyu marked this pull request as ready for review November 29, 2022 02:03
@ganglyu ganglyu requested a review from xumia as a code owner November 29, 2022 02:03
@ganglyu ganglyu requested a review from liuh-80 November 29, 2022 02:04
Copy link
Contributor

@liuh-80 liuh-80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the submodule change includes some commit not related to native write, suggest move the submodule update to a new PR and merge first.

Copy link
Contributor

@liuh-80 liuh-80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR depends on another submodule PR, suggest run validation again after submodule PR merged to master branch to make sure not conflict or build break.

@ganglyu ganglyu merged commit c16b8db into sonic-net:master Nov 29, 2022
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this pull request Dec 8, 2022
Why I did it
Provide GNMI native write interface for configuration.

How I did it
Add configuration parameters for GNMI native write.

How to verify it
Check build pipeline.
StormLiangMS pushed a commit that referenced this pull request Dec 10, 2022
Why I did it
Provide GNMI native write interface for configuration.

How I did it
Add configuration parameters for GNMI native write.

How to verify it
Check build pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants