-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update include_macsec flag if type is SpineRouter #11141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for multi-asic platforms. This will be used by features running in namesapces Also add the support to enable macsec when type is SpineRouter
judyjoseph
changed the title
Update the feature table in STATE_DB in database running in namespace
Update the feature state in STATE_DB in namespace database
Jun 14, 2022
judyjoseph
commented
Jun 15, 2022
judyjoseph
changed the title
Update the feature state in STATE_DB in namespace database
Update include_macsec flag if type is SpineRouter
Jun 23, 2022
arlakshm
approved these changes
Jun 23, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 28, 2022
Add the support to enable macsec when type is SpineRouter
judyjoseph
added a commit
that referenced
this pull request
Jun 30, 2022
This reverts commit c9f3695.
7 tasks
judyjoseph
added a commit
that referenced
this pull request
Jul 1, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 5, 2022
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
Add the support to enable macsec when type is SpineRouter
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
…11141)" (sonic-net#11306) This reverts commit c9f3695.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Update the feature table in STATE_DB in database running in namespace for multi-asic platforms.
This will be used by features running in namespaces.
This is needed by features like sonic-net/sonic-swss#2286, which need to know the state of feature before adding feature based condition
Also add the support to enable macsec when type == "SpineRouter"
How I did it
Updated the init_cfg.json.j2 file and hostcfgd.
How to verify it
Verified with feature running in multiple namespaces
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)