Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yang_config_validation in device_info #11715

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Aug 12, 2022

Why I did it

Put yang_config_validation in common lib and make it reusabe

How I did it

Move the definition to device_info.py

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@@ -403,6 +403,10 @@ def get_chassis_info():

return chassis_info_dict


def is_yang_config_validation_enabled(config_db=None):
Copy link
Collaborator

@qiluo-msft qiluo-msft Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=None

For new code, let's remove =None. #Closed

This reverts commit 644476b.
@wen587 wen587 marked this pull request as ready for review August 17, 2022 03:06
@wen587 wen587 merged commit 5846cdd into sonic-net:master Aug 17, 2022
yxieca pushed a commit that referenced this pull request Aug 17, 2022
Why I did it
Put yang_config_validation in common lib and make it reusabe

How I did it
Move the definition to device_info.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants