Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Remove approve step in label action. #11968

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

liushilongbuaa
Copy link
Contributor

Why I did it

Approve step needs special permission settings. We already added permission setting to enable bypass merging PR.
So, approve step is not necessary.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa liushilongbuaa marked this pull request as ready for review September 5, 2022 06:39
@liushilongbuaa liushilongbuaa merged commit 1411205 into sonic-net:202012 Sep 5, 2022
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 8, 2022
Why I did it
Approve step needs special permission settings.
We already added permission setting to enable bypass merging PR.
So, approve step is not necessary.
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 8, 2022
Why I did it
Approve step needs special permission settings.
We already added permission setting to enable bypass merging PR.
So, approve step is not necessary.
liushilongbuaa added a commit that referenced this pull request Sep 8, 2022
Why I did it
Approve step needs special permission settings.
We already added permission setting to enable bypass merging PR.
So, approve step is not necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants