03.Version-cache - framework environment settings #12003
Conversation
Kalimuthu-Velappan
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@xumia @liushilongbuaa submitter has taken the time to split the original code PR to smaller submissions for review, pls help take a look |
Kalimuthu-Velappan
force-pushed
the
ENV_SETTINGS
branch
2 times, most recently
from
86c7b6a to
e1ad560
Compare
rules/functions
Outdated
| LOG_SAVE = |& $(PROJECT_ROOT)/scripts/process_log.sh $(PROCESS_LOG_OPTION) &>> $(PROJECT_ROOT)/$@.log ; test $${PIPESTATUS[-2]} -eq 0 || { [ $$? -eq 0 ] || pushd $(PROJECT_ROOT) > /dev/null ; ./update_screen.sh -e $@ ; popd > /dev/null ; false ; } | ||
| LOG = < /dev/null |& $(PROJECT_ROOT)/scripts/process_log.sh $(PROCESS_LOG_OPTION) &>> $(PROJECT_ROOT)/$@.log ; test $${PIPESTATUS[-2]} -eq 0 || { [ $$? -eq 0 ] || pushd $(PROJECT_ROOT) > /dev/null ; ./update_screen.sh -e $@ ; popd > /dev/null ; false ; } |
There was a problem hiding this comment.
Is it possible to use the same variable form LOG_SAVE and LOG? Looks like the only difference is the "< /dev/null " in the variable LOG.
| # Decode the cache content into gz format | ||
| SRC_VERSION_PATH=files/build/versions | ||
| if [[ -e ${CACHE_ENCODE_FILE} ]]; then | ||
|
|
There was a problem hiding this comment.
removing the empty line 47?
| local filename=$(dirname $1) | ||
| local timeout=${2:-360} |
There was a problem hiding this comment.
Could you please fix the tab/space format issue?
Kalimuthu-Velappan
force-pushed
the
ENV_SETTINGS
branch
from
e1ad560 to
001ba50
Compare
|
@xumia @liushilongbuaa can you please review the PR? Thanks. |
Kalimuthu-Velappan
force-pushed
the
ENV_SETTINGS
branch
3 times, most recently
from
1c4c75d to
a38b1c6
Compare
It defines and passes the necessary version cache environment variables
to the caching framework.
It adds the utils script for shared cache file access.
It also adds the post-cleanup logic for cleaning the unwanted files from
the docker/image after the version cache creation.
The following variable controls the version caching feature. By default, it is turned off.
SONIC_VERSION_CACHE_METHOD = [none/cache]
SONIC_VERSION_CACHE_SOURCE = /path/to/local/storage
Kalimuthu-Velappan
force-pushed
the
ENV_SETTINGS
branch
from
a38b1c6 to
04a7b7e
Compare
| @@ -558,7 +563,7 @@ $(addprefix $(DEBS_PATH)/, $(SONIC_ONLINE_DEBS)) : $(DEBS_PATH)/% : .platform \ | |||
| if [ -z '$($*_CACHE_LOADED)' ] ; then | |||
|
|
|||
| $(foreach deb,$* $($*_DERIVED_DEBS), \ | |||
| { curl -L -f -o $(DEBS_PATH)/$(deb) $($(deb)_CURL_OPTIONS) $($(deb)_URL) $(LOG) || { exit 1 ; } } ; ) | |||
| { SKIP_BUILD_HOOK=$($*_SKIP_VERSION) curl -L -f -o $(DEBS_PATH)/$(deb) $($(deb)_CURL_OPTIONS) $($(deb)_URL) $(LOG) || { exit 1 ; } } ; ) | |||
There was a problem hiding this comment.
Why we need to skip it? Can we keep the build hook?
There was a problem hiding this comment.
Any particular package that wants to skip versioning selectively can define as below. Eg:
$(BRCM_SAI)_SKIP_VERSION=y
|
@Kalimuthu-Velappan , could you please update the description? Add something in the Why/How/How parts, thanks. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It is merged as part of |
It defines and passes the necessary version cache environment variables to the caching framework.
It adds the utils script for shared cache file access.
It also adds the post-cleanup logic for cleaning the unwanted files from the docker/image after the version cache creation.
The following variable controls the version caching feature. By default, it is turned off.
SONIC_VERSION_CACHE_METHOD = [none/cache]
SONIC_VERSION_CACHE_SOURCE = /path/to/local/storage
Why I did it
It provides a framework for caching build files during the docker build.
How I did it
It uses three staging processes to create a sonic docker image.
How to verify it
Cache files are created under the version cache path after the build.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)