Makefile: Fix the issue when $(PLATFORM_PATH) is empty #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
changed the title
lguohan
reviewed
Dec 15, 2016
| @@ -166,6 +166,7 @@ sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install \ | |||
| file \ | |||
| ifupdown \ | |||
| iproute2 \ | |||
| iptables-persistent \ | |||
There was a problem hiding this comment.
what is this? not related to the commit?
There was a problem hiding this comment.
oh this is not related to this pull request.
lguohan
reviewed
Dec 15, 2016
| @@ -51,7 +51,7 @@ distclean : .platform clean | |||
| include $(RULES_PATH)/config | |||
| include $(RULES_PATH)/functions | |||
| include $(RULES_PATH)/*.mk | |||
| ifneq ($(CONFIGURED_PLATFORM), undefined) | |||
| ifneq ($(wildcard $(PLATFORM_PATH)),) | |||
There was a problem hiding this comment.
if the .platform file exists but empty, the make command will fail as the $(CONFIGURED_PLATFORM) is not undefined. With this fix, the make command will not fail unexpectedly.
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
* [show]: Remove default groups; add missing docstrings * Copy all bash completion files by glob
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
lguohan
pushed a commit
that referenced
this pull request
Sep 26, 2020
* src/sonic-platform-common 7255d3a...111dcf7 (2): > [EEPROM] Add new function part_number_str to TlvInfoDecoder (#121) > Fix fp_port_index error to get correct index type (#111)
vdahiya12
pushed a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Oct 2, 2020
…t#121) Add a new function to TlvInfoDecoder which can return device part number as a string.
abdosi
added a commit
that referenced
this pull request
Oct 6, 2020
[EEPROM] Add new function part_number_str to TlvInfoDecoder (#121) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
xumia
pushed a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Feb 16, 2021
* Install SONiC YANG package * Move relative paths for utilities tests Signed-off-by: Danny Allen <daall@microsoft.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* src/sonic-platform-common 7255d3a...111dcf7 (2): > [EEPROM] Add new function part_number_str to TlvInfoDecoder (sonic-net#121) > Fix fp_port_index error to get correct index type (sonic-net#111)
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jan 24, 2022
Fixes the following crash introduced by sonic-net/sonic-platform-daemons#102: ``` 01:33:00 ______________________ test_updater_thermal_check_min_max ______________________ 01:33:00 01:33:00 def test_updater_thermal_check_min_max(): 01:33:00 chassis = MockChassis() 01:33:00 01:33:00 thermal = MockThermal() 01:33:00 chassis.get_all_thermals().append(thermal) 01:33:00 01:33:00 chassis.set_modular_chassis(True) 01:33:00 chassis.set_my_slot(1) 01:33:00 temperature_updater = TemperatureUpdater(SYSLOG_IDENTIFIER, chassis) 01:33:00 01:33:00 temperature_updater.update() 01:33:00 slot_dict = temperature_updater.chassis_table.get('Thermal 1') 01:33:00 > assert slot_dict['minimum_temperature'] == str(thermal.get_minimum_recorded()) 01:33:00 E TypeError: 'NoneType' object has no attribute '__getitem__' 01:33:00 01:33:00 tests/test_thermalctld.py:341: TypeError ``` Signed-off-by: Petro Bratash <petrox.bratash@intel.com> Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
sg893052
pushed a commit
to sg893052/sonic-buildimage
that referenced
this pull request
Apr 25, 2022
BFD scaling with aggressive timers
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Aug 18, 2022
…submodule head linkmgrd: * 476f85e 2022-08-17 | Update linkmgr health after getting default route update (sonic-net#117) (HEAD -> 202205, github/202205) [Longxiang Lyu] * fc589e9 2022-08-17 | Use `table` to toggle peer forwarding state (sonic-net#108) (sonic-net#120) [Longxiang Lyu] * bcb5a56 2022-08-17 | Fix azure pipeline (sonic-net#118) (sonic-net#121) [Longxiang Lyu] swss: * ef3a601 2022-08-17 | [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() (sonic-net#2415) (HEAD -> 202205) [Nikola Dancejic] sairedis: * aed01cd 2022-08-12 | Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#1072) (sonic-net#1104) (github/202205) [Hua Liu] platform-daemon: * 5a68073 2022-08-01 | Xcvrd changes to support 400G ZR configuration (sonic-net#270) (HEAD -> 202205) [Prince George] swsssdk: * ca785a2 2022-06-01 | Remove sonic-db-cli (sonic-net#122) (HEAD -> 202205, origin/202205) [Hua Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Aug 19, 2022
…submodule head (#11761) linkmgrd: * 476f85e 2022-08-17 | Update linkmgr health after getting default route update (#117) (HEAD -> 202205, github/202205) [Longxiang Lyu] * fc589e9 2022-08-17 | Use `table` to toggle peer forwarding state (#108) (#120) [Longxiang Lyu] * bcb5a56 2022-08-17 | Fix azure pipeline (#118) (#121) [Longxiang Lyu] swss: * ef3a601 2022-08-17 | [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() (#2415) (HEAD -> 202205) [Nikola Dancejic] sairedis: * aed01cd 2022-08-12 | Fix: missing sonic-db-cli in docker-sonic-vs image (#1072) (#1104) (github/202205) [Hua Liu] platform-daemon: * 5a68073 2022-08-01 | Xcvrd changes to support 400G ZR configuration (#270) (HEAD -> 202205) [Prince George] swsssdk: * ca785a2 2022-06-01 | Remove sonic-db-cli (#122) (HEAD -> 202205, origin/202205) [Hua Liu] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-buildimage
that referenced
this pull request
Apr 11, 2023
Why I did it Use fixed cert, and gnmi client doesn't need to update cert for new test container. How I did it Add fixed cert and key to repo. How to verify it Use GNMI test container to run basic test.
10 tasks
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Apr 28, 2023
- remove fix_ismt_alignment_issue.patch
linux commit id: 5cd5f0bb0d9c32876b3d86b70fb45da10d028be7
- remove 0011-support-Broadcom-54616-Phy-for-Intel-igb-driver.patch
linux commit id: eeb0149660a21c61122d4937bd406aa4f334c1e4
- remove driver-l3mdev-cgroup.patch
- remove config-l3mdev-cgroup.patch
- remove bridge-add-per-port-broadcast-flood-flag.patch
linux commit id: 99f906e9ad7b6e79ffeda30f45906a8448b9d6a2
- remove 0025-net-udp_l3mdev_accept-support.patch
linux commit id: 63a6fff353d01da5a22b72670c434bf12fa0e3b8
- remove kernel-enable-psample-and-act_sample-drivers.patch
- remove mellanox-backport-introduce-psample-a-new-genetlink-channel.patch
linux commit id: 6ae0a6286171154661b74f7f550f9441c6008424
- remove mellanox-backport-introduce-tc-sample-action.patch
linux commit id: 5c5670fae43027778e84b9d9ff3b9d91a10a8131
- remove 0000-net-Fix-netdev-adjacency-tracking.patch
linux commit id: 67b62f98a1de962277b60d77c0c208b76867dbae
0f524a80ff35af8a7664d7661d948107da142e04
f1170fd462c67c4ae2f20734566d94e0f8f62f69
1a3f060c1a47dba4e12ac21ce62b57666b9c4e95
790510d99f39cee7f275d001aa5024032ed9bb48
453d39329ad03f9f6d93ec6d0d57bf7a1e2a20c7
e0e79c8e74b08976d9b45e52b704b9228c6965c7
b3208b2024c9089106df52ae25ebf39068d6f9fc
1cd127fc7d3a6d6a0fc9f9cca47ca3a16ee79679
dd82364c3ab93a96bb1e45d22106a4b1ea4bef39
cf2d67408b2f9a840f27d25a0219070b5b5deec4
- remove 0000-net-ipv6-ll-anycast-mcast-routes-on-dev.patch
linux commit id: 4832c30d5458387ff2533ff66fbde26ad8bb5a2d
- remove 0001-net-ipv6-Allow-shorthand-delete-of-all-nexthops-in-m.patch
linux commit id: 0ae8133586ad1c9be894411aaf8b17bb58c8efe5
- remove linux-4.13-thermal-intel_pch_thermal-Fix-enable-check-on.patch
linux commit id: 595536e0b2475a9eac23709cd461143178c12e0e
- remove linux-4.16-firmware-dmi-handle-missing-DMI-data-gracefully.patch
linux commit id: a81114d03e4a529c4b68293249f75438b3c1783f
Signed-off-by: Guohan Lu <gulv@microsoft.com>
* [Mellanox] Port the patches to 4.19 (#14)
0001-v4.19-6-Mellanox-platform-Backport-patches-for-new-M.patch
0002-config-mellanox-configuration.patch
0003-mlxsw-minimal-Fix-validation-for-FW-minor-version.patch
0004-mlxsw-core-Add-the-hottest-thermal-zone-detection.patch
0005-hwmon-pmbus-core-Add-support-for-vid-mode-detection-.patch
0006-platform-mellanox-mlxreg-hotplug-Use-capability-r.patch
<linux/i2c/pmbus.h> -> <linux/pmbus.h>
Remove files which are no longer used.
Co-authored-by: stephens <stephens@contoso.com>
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…lly (sonic-net#15504) #### Why I did it src/sonic-gnmi ``` * a600dc9 - (HEAD -> master, origin/master, origin/HEAD) Fix threading issues in Event Client (sonic-net#121) (9 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.