asyncsnmp depends on sonic-utilities so it is possible to import sonic_psu #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Dec 7, 2017
lguohan
approved these changes
Dec 7, 2017
qiluo-msft
force-pushed
the
qiluo/sonic_psu
branch
from
8775cc3
to
9bdc8b4
Compare
lguohan
reviewed
Dec 7, 2017
slave.mk
Outdated
| # How to remove the ugly second test? | ||
| # 1. The unittest module from 3.6 does well | ||
| # 2. Not to use conditional test_suite, so recursively refine all the dependencies | ||
| python$($*_PYTHON_VERSION) setup.py test $(LOG) || python$($*_PYTHON_VERSION) setup.py test $(LOG) |
There was a problem hiding this comment.
I would add a build option to not to test in this case. #Resolved
lguohan
reviewed
Dec 7, 2017
| # Note: _DEPENDS macro is not defined | ||
| SONIC_UTILS_PY3 = sonic_utilities-1.1-py3-none-any.whl | ||
| $(SONIC_UTILS_PY3)_SRC_PATH = $(SRC_PATH)/sonic-utilities | ||
| $(SONIC_UTILS_PY3)_PYTHON_VERSION = 3 |
There was a problem hiding this comment.
We can add
$(SONIC_UTILS_PY3)_TEST = n to disable the test.
It is more useful. #Resolved
lguohan
reviewed
Dec 7, 2017
slave.mk
Outdated
| # How to remove the ugly second test? | ||
| # 1. The unittest module from 3.6 does well | ||
| # 2. Not to use conditional test_suite, so recursively refine all the dependencies | ||
| python$($*_PYTHON_VERSION) setup.py test $(LOG) || python$($*_PYTHON_VERSION) setup.py test $(LOG) |
There was a problem hiding this comment.
$(if $($*_TEST), python$($*_PYTHON_VERSION) setup.py test $(LOG))
``` #Resolved
There was a problem hiding this comment.
…c_psu Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
qiluo-msft
force-pushed
the
qiluo/sonic_psu
branch
from
9bdc8b4
to
ec1f46b
Compare
|
wait for build |
abdosi
added a commit
that referenced
this pull request
Mar 4, 2020
Enable m_isCombinedMirrorV6Table for BFN platform (#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (#1132) Default action for Egress ACL Table not poulated. (#1208) Add/Del lag_name_map item according to lag adding and removing (#1124) Increase ip2me CIR/CBR for faster in-band file transfers (#1000)
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
Enable m_isCombinedMirrorV6Table for BFN platform (sonic-net#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132) Default action for Egress ACL Table not poulated. (sonic-net#1208) Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124) Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Enable m_isCombinedMirrorV6Table for BFN platform (sonic-net#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132) Default action for Egress ACL Table not poulated. (sonic-net#1208) Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124) Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-sairedis submodule pointer to include the following: * 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Mar 10, 2023
Update sonic-sairedis submodule pointer to include the following: * 4bd1dc5 Fast reboot finalizer ([sonic-net#1213](sonic-net/sonic-sairedis#1213)) * 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Mar 12, 2023
Update sonic-sairedis submodule pointer to include the following: * 4bd1dc5 Fast reboot finalizer ([#1213](sonic-net/sonic-sairedis#1213)) * 749b393 [ci] Fix apt-get install unable locate package issue. ([#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
Build snmp docker and test importing in python3.6
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)