Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzurePipeline] Fix vstest step failed by libyang missing. #12240

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Sep 30, 2022

[AzurePipeline] Fix vstest step failed by libyang missing.

Why I did it

Fix PR merge failed because 'vstest' step does not install libyang.

How I did it

Install libyang in azure pipeline.

How to verify it

Pass vstest step.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

[AzurePipeline] Fix vstest step failed by libyang missing.

Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 requested review from xumia and qiluo-msft September 30, 2022 05:00
@liuh-80 liuh-80 marked this pull request as ready for review September 30, 2022 05:00
@liuh-80 liuh-80 requested a review from lguohan as a code owner September 30, 2022 05:00
@xumia xumia added the ci label Sep 30, 2022
@@ -113,6 +113,7 @@ stages:

- script: |
set -x
sudo apt-get install libyang libyang-dev
Copy link
Collaborator

@xumia xumia Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need a -y, some time it will wait forever without '-y'.
sudo apt-get update
sudo apt-get install -y libyang libyang-dev

Better to add apt-get update, if the image has not been updated for a long time the local cache of the Debian package index might be out of date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@xumia xumia merged commit 004a8b6 into sonic-net:master Sep 30, 2022
@xumia
Copy link
Collaborator

xumia commented Sep 30, 2022

Merged the PR by force.
Reason: CI change only, it blocks multiple PRs.

yxieca pushed a commit that referenced this pull request Oct 3, 2022
Why I did it
Fix PR merge failed because 'vstest' step does not install libyang.

How I did it
Install libyang in azure pipeline.

How to verify it
Pass vstest step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants