Add k8s master table yang model #12331
Conversation
Signed-off-by: Yun Li <yunli1@microsoft.com>
lixiaoyuner
force-pushed
the
add_k8s_master_table_yang_model
branch
from
295a708
to
c7798f9
Compare
|
|
||
| leaf ip { | ||
| description "Kubernetes api server endpoint"; | ||
| type string; |
There was a problem hiding this comment.
This should use IPAddress type
There was a problem hiding this comment.
It should be IPAddress type and DNS domain type, currently use inet:host to cover both of them.
| description "This configuration identicates it will download kubernetes | ||
| CA by http other than https"; | ||
| type stypes:boolean_type; | ||
| default "true"; |
There was a problem hiding this comment.
This should be false too.
There was a problem hiding this comment.
Currently sonic join logic is to download k8a default ca.crt and combine it with local ame certificate, we get the kubeconfig credential. The default ca.crt is stored in k8s configmap, we download it from apiserver endpoint, and sonic impossibly have the default ca.crt, but if sonic want to establish secure connection with apiserver, sonic needs k8s default ca.crt. So, the downloading k8s default ca request can only be insecure currently. So, I set the default value "true".
|
@praveen-li, Please review this PR. |
|
Would you please update doc/Configuration.md? |
Updated |
Signed-off-by: Yun Li yunli1@microsoft.com
Why I did it
Add k8s master table yang model
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)