Revert "01.Version-cache - restructuring of Makefile.work" #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c691b73.
saiarcot895
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
xumia
approved these changes
Oct 12, 2022
7 tasks
|
I have fixed the issue in the below PR, still you want to revert? |
|
I'm fine with a fix. I didn't see a quick fix, and so opened a PR to revert it. |
|
Closing this in favor of #12369 |
Kalimuthu-Velappan
added a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Oct 13, 2022
This PR fixes the issue reported in PR#12367 sonic-net#12367 The issue is that exit code always being 0 for the builds that are failed. Fix is added in the Makefile.work to return the error code when the slave build is failed with an error.
xumia
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR fixes the issue reported in PR#12367 #12367 The issue is that exit code always being 0 for the builds that are failed. Fix is added in the Makefile.work to return the error code when the slave build is failed with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12000
Changes in this PR are resulting in the exit code always being 0 for builds that failed. See #12344 as an example. This is causing builds to appear as successful when they're not.
Tested by using
make -f Makefile.work BLDENV=buster SONIC_BUILD_JOBS=6 target/debs/buster/libsaithriftv2-dev_0.9.4_amd64.debas the build command. This is an invalid build target, sinceSAITHRIFT_V2isn't enabled, and so the above target cannot be built. At95f4af3(before this PR), the command has an exit code of 2 (which is correct). Atc691b73, this command has an exit code of 0 (which is incorrect). For the sake of time, the slave container tags have been hardcoded inMakefile.work.