-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BUILD flags to provision for building the kernel with non-upstream patches #12428
Conversation
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use imperative mood in git commit messages summaries/titles, and merge/pull request summaries/titles. s/Added/Add/
### Structure of the patch archive | ||
|
||
1. The tarball should be gzip compressed i.e. of extension .tar.gz | ||
2. It should contain a file named series. series should provide an order of which the patches have to be applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate, how to create such a series file.
platform/mellanox/rules.mk
Outdated
@@ -51,4 +51,9 @@ $(DOCKER_PLATFORM_MONITOR)_DEPENDS += $(APPLIBS) $(SX_COMPLIB) $(SXD_LIBS) $(SX_ | |||
# Force the target bootloader for mellanox platforms to grub regardless of arch | |||
TARGET_BOOTLOADER = grub | |||
|
|||
# Set y to include non upstream patches for mellanox | |||
INCLUDE_MLNX_PATCHES = n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Can’t patches for other subsystems be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other subsystems planning to include non-upstream patches can use EXTERNAL_KERNEL_PATCHES flag to provide a public accessible link to the tarball
@saiarcot895 please review |
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@saiarcot895, I've updated the pr according to the comments given sonic-net/sonic-linux-kernel#296. Can you also review this? |
…eam patches (sonic-net#12428) * Added ENV vars for non-upstream patches Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Made MLNX_PATCH_LOC an absolute path Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Added non-upstream-patches dir Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Update README.md * Addressed comments * Env vars updated Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Readme updated Signed-off-by: Vivek Reddy <vkarri@nvidia.com> Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy vkarri@nvidia.com
Why I did it
Provide a way to include non-upstream kernel patches in the kernel build process
Requires sonic-net/sonic-linux-kernel#296 and can be merged in any order
How I did it
Introduced two new environment variables:
Note: For
INCLUDE_EXTERNAL_PATCH_TAR
to work, the platform has to overrideEXTERNAL_KERNEL_PATCH_TAR
variable. And the variable should be a path pointing to the tarball containing patchesUse SONIC_OVERRIDE_BUILD_VARS to fuse in these env variables:
Structure of the patch tar archive
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)