Add yang_config_validation to DEVICE_METADATA yang model #12497
Merged
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ganglyu could you check? |
ganglyu
reviewed
Oct 26, 2022
src/sonic-config-engine/minigraph.py
Outdated
| @@ -1450,7 +1450,8 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw | |||
| 'hostname': hostname, | |||
| 'hwsku': hwsku, | |||
| 'type': device_type, | |||
| 'synchronous_mode': 'enable' | |||
| 'synchronous_mode': 'enable', | |||
| 'yang_config_validation': 'disable' | |||
There was a problem hiding this comment.
Please create another PR for sonic-config-engine, and update unit test for sonic-config-engine.
There was a problem hiding this comment.
Created separate PR
ganglyu
reviewed
Oct 26, 2022
| @@ -119,6 +119,14 @@ module sonic-device_metadata { | |||
| default enable; | |||
| } | |||
|
|
|||
| leaf yang_config_validation { | |||
| type enumeration { | |||
There was a problem hiding this comment.
Can you use mode-status instead?
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L178
There was a problem hiding this comment.
Changed to use stypes:mode-status
|
Please update Configuration.md and sample_config_db.json. |
ganglyu
approved these changes
Oct 26, 2022
ganglyu
approved these changes
Oct 26, 2022
isabelmsft
changed the title
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
New field
yang_config_validationneeds to be represented in DEVICE_METADATA yang model, configured in minigraph.pyHow I did it
Add field to yang model, set value in minigraph.py
How to verify it
Use GCU to apply patch configuring
yang_config_validationfieldDescription for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.