Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][mellanox]Fix CPLD upgrade script #13240

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

dgsudharsan
Copy link
Collaborator

Why I did it

Fixed CPLD upgrade script

How I did it

Modified the skip check to be greater than or equal to compared to equal to previously

How to verify it

Upgrade image with changes

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Contributor

prgeor commented Jan 4, 2023

@dgsudharsan did you test the following cases

  1. Device already running with latest CPLD and then firmware upgrade skips CPLD upgrade
  2. Device has old CPLD and firmware upgrade upgrades to higher version?

@dgsudharsan
Copy link
Collaborator Author

@dgsudharsan did you test the following cases

  1. Device already running with latest CPLD and then firmware upgrade skips CPLD upgrade
  2. Device has old CPLD and firmware upgrade upgrades to higher version?

Hi @prgeor . Tested both cases and it works good.

@prgeor
Copy link
Contributor

prgeor commented Jan 5, 2023

@rlhui please help merge this to 2019

@lguohan lguohan merged commit 2a8153a into sonic-net:201911 Jan 6, 2023
@dgsudharsan dgsudharsan deleted the cpld_fix_1911 branch March 9, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants