Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205] Update BRCM SAI version to 7.1.31.4 #13346

Merged
merged 2 commits into from
Jan 13, 2023
Merged

[202205] Update BRCM SAI version to 7.1.31.4 #13346

merged 2 commits into from
Jan 13, 2023

Conversation

tjchadaga
Copy link
Contributor

Why I did it

To bring in the following fixes:

  1. Revert temporary fix added to disable SA equal DA drops
  2. CS00012273013 - [7.1][J2, J2c+] Disable SA Equals DA trap on DNX
  3. CS00012274222 - How to block the voq for given destination port for a flow from a remote mod-id
  4. CS00012275381 - SAI_INGRESS_PRIORITY_GROUP_STAT_PACKETS is incremented for port's PG's even if there are no traffic sent to that PG
  5. CS00012274433 - Local Fault and Remote Fault are not polled by linkscan thread

How I did it

Merged above fixes to SAI code

How to verify it

Validated by running the basic sanity tests on XGS and DNX chassis platforms including

  1. fib/test_fib.py
  2. decap/test_decap.py
  3. drop_counters/test_drop_counters.py
  4. arp/test_arpall.py

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Collaborator

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjchadaga tjchadaga requested a review from yxieca January 12, 2023 20:02
@lguohan lguohan merged commit 3c485e0 into sonic-net:202205 Jan 13, 2023
lguohan pushed a commit that referenced this pull request Nov 29, 2023
This change was submitted directly to 202205 but it's also needed in master and 202305 with SAI9.x
#13346

There has been a couple CSPs for this as well:
CS00012273013 - [7.1][J2, J2c+] Disable SA Equals DA trap on DNX
CS00012320965 - SAI9.2: iBGP doesn't work due to SA_EQUALS_DA trap

If SA_EQUALS_DA trap is enabled iBGP won't work as the Ethernet-IB0 ports are expected to get packets with SA==DA.

In the VOQ chassis design, for outgoing control plane packets, the packets goes the recycle port for routing, therefore the dmac of the packet should be the asic router mac. The source mac is assigned by the kernel, so it is also the asic router mac.
yxieca pushed a commit that referenced this pull request Dec 4, 2023
This change was submitted directly to 202205 but it's also needed in master and 202305 with SAI9.x
#13346

There has been a couple CSPs for this as well:
CS00012273013 - [7.1][J2, J2c+] Disable SA Equals DA trap on DNX
CS00012320965 - SAI9.2: iBGP doesn't work due to SA_EQUALS_DA trap

If SA_EQUALS_DA trap is enabled iBGP won't work as the Ethernet-IB0 ports are expected to get packets with SA==DA.

In the VOQ chassis design, for outgoing control plane packets, the packets goes the recycle port for routing, therefore the dmac of the packet should be the asic router mac. The source mac is assigned by the kernel, so it is also the asic router mac.
lguohan pushed a commit that referenced this pull request Mar 27, 2024
…en the MAC_SA=MAC_DA (#18446)

The SAI code was modified to trap and drop the packets if the MAC_SA==MAC_DA and soc variable sai_disable_srcmacqedstmac_ctrl=1 needs to be set in bcm config. There was a PR #13346 which added updated bcm config in 202205, but never merged to master.

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants