Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonic-slave-* build errors about sudo command not found #13412

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Jan 18, 2023

Why I did it

issue #13395

  1. Fix a bug about sudo failure.
/usr/local/share/buildinfo/scripts/buildinfo_base.sh: line 24: sudo: command not found
  1. Fix an issue about warning message.
./scripts/run_with_retry: line 4: [: : integer expression expected

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan linked an issue Jan 18, 2023 that may be closed by this pull request
scripts/run_with_retry Show resolved Hide resolved
@liat-grozovik
Copy link
Collaborator

@xumia as this is a blocking issue on many builds we should take it as is but I think @nazariig has a good point and suggest to re evaluate the fix moving forward.

@liat-grozovik liat-grozovik merged commit 6ba1a2e into sonic-net:master Jan 31, 2023
@liushilongbuaa
Copy link
Contributor Author

@liat-grozovik , Thanks for merging it.
FYI. It is not blocking issue. If someone is debugging build break, this PR maybe don't help.

@nazariig
Copy link
Collaborator

PR contains a fix: #12325

@mssonicbld
Copy link
Collaborator

@liushilongbuaa PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

@liushilongbuaa PR conflicts with 202012 branch

@mssonicbld
Copy link
Collaborator

@liushilongbuaa PR conflicts with 202211 branch

bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Apr 23, 2023
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Apr 30, 2023
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Apr 30, 2023
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request May 15, 2023
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Oct 31, 2023
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Jan 21, 2024
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Feb 19, 2024
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Feb 19, 2024
bluecmd added a commit to kamelnetworks/sonic-buildimage that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[buildsystem]: Errors are seen during privilege escalation
8 participants