-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sudoers] add /usr/local/bin/storyteller
to READ_ONLY_CMDS
#13422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Jan 19, 2023
Hi @yxieca - please help merge. Thanks! |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 27, 2023
…-net#13422) Adding /usr/local/bin/storyteller to READ_ONLY_CMDS. So no write access or prompt for password is needed to run storyteller. Tested on 202205 clusters, user who didn't request write access was able to grep log using storyteller. sign-off: Jing Zhang zhangjing@microsoft.com
Cherry-pick PR to 202205: #13530 |
mssonicbld
added a commit
that referenced
this pull request
Jan 27, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 5, 2023
…-net#13422) Adding /usr/local/bin/storyteller to READ_ONLY_CMDS. So no write access or prompt for password is needed to run storyteller. Tested on 202205 clusters, user who didn't request write access was able to grep log using storyteller. sign-off: Jing Zhang zhangjing@microsoft.com
Cherry-pick PR to 202211: #13666 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 7, 2023
Adding /usr/local/bin/storyteller to READ_ONLY_CMDS. So no write access or prompt for password is needed to run storyteller. Tested on 202205 clusters, user who didn't request write access was able to grep log using storyteller. sign-off: Jing Zhang zhangjing@microsoft.com
maipbui
added a commit
to maipbui/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
sonic-net#13422)" This reverts commit dabb31c.
13 tasks
maipbui
added a commit
to maipbui/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
sonic-net#13422)" This reverts commit dabb31c.
This was referenced Jul 18, 2024
maipbui
added a commit
to maipbui/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
sonic-net#13422)" This reverts commit dabb31c.
11 tasks
maipbui
added a commit
to maipbui/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
sonic-net#13422)" This reverts commit dabb31c.
11 tasks
maipbui
added a commit
to maipbui/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
sonic-net#13422) (sonic-net#13530)" This reverts commit 3860186.
yxieca
pushed a commit
that referenced
this pull request
Jul 18, 2024
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
sonic-net#13422)" (sonic-net#19612) This reverts commit dabb31c.
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
sonic-net#13422)" (sonic-net#19612) This reverts commit dabb31c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
/usr/local/bin/storyteller
toREAD_ONLY_CMDS
. So no write access or prompt for password is needed to runstoryteller
.Tested on 202205 clusters, user who didn't request write access was able to grep log using storyteller.
sign-off: Jing Zhang zhangjing@microsoft.com