Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yang]Add FG-ECMP yang model #13443

Closed
wants to merge 9 commits into from
Closed

[yang]Add FG-ECMP yang model #13443

wants to merge 9 commits into from

Conversation

lmingz
Copy link
Contributor

@lmingz lmingz commented Jan 19, 2023

Why I did it

Add yang model definition for FG_NHG_MEMBER, FG_NHG and FG_NHG_PREFIX from request: #12457

How I did it

Add yang model refereeing to description https://github.com/sonic-net/SONiC/blob/master/doc/ecmp/fine_grained_next_hop_hld.md

How to verify it

pyang tests

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • [x ] 202211

Description for the changelog

Add yang model for FG_NHG_MEMBER, FG_NHG and FG_NHG_PREFIX

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

@lmingz lmingz requested a review from qiluo-msft as a code owner January 19, 2023 19:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lmingz lmingz marked this pull request as draft January 19, 2023 19:24
@lmingz lmingz marked this pull request as ready for review January 19, 2023 19:26
@lmingz lmingz marked this pull request as draft January 19, 2023 19:27
@qiluo-msft qiluo-msft requested a review from ganglyu January 19, 2023 23:35
@ganglyu
Copy link
Contributor

ganglyu commented Jan 20, 2023

Would you please update setup.py and add unit test?
You can refer to this PR: #12689

@zhangyanzhao zhangyanzhao changed the title Add FG-ECMP yang model [yang]Add FG-ECMP yang model Jan 26, 2023
@ganglyu
Copy link
Contributor

ganglyu commented Jan 27, 2023

src/sonic-yang-models/tests/files/sample_config_db.json
We need to update above file for new tables.

@ganglyu
Copy link
Contributor

ganglyu commented Jan 28, 2023

Please check this unit test:
------------------- Test 540: VALID_FINE_GRAINED_ECMP no failure.---------------------
libyang[0]: Unknown element "FG_NHG_PREFIX_LIST". (path: /sonic-fine-grained-ecmp:sonic-fine-grained-ecmp/FG_NHG)
INFO:YANG-TEST:Unknown element "FG_NHG_PREFIX_LIST".
ERROR:YANG-TEST: Exception >Unknown element "FG_NHG_PREFIX_LIST". in not empty< in /sonic/src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py:208
INFO:YANG-TEST:VALID_FINE_GRAINED_ECMP no failure. Failed

@zhangyanzhao
Copy link
Collaborator

@lmingz can you please sign off the EasyCLA? That is required to merge your code. Thanks.

@zhangyanzhao
Copy link
Collaborator

UT need be improved.

@zhangyanzhao zhangyanzhao added the YANG YANG model related changes label Feb 2, 2023
@lmingz
Copy link
Contributor Author

lmingz commented Feb 2, 2023 via email

@lmingz lmingz closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganglyu ganglyu ganglyu left review comments

@anish-n anish-n anish-n left review comments

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees
No one assigned
Labels
YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmingz @ganglyu @zhangyanzhao @anish-n