Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-cfggen] Enhance ACL unit test to also test control plane (service) ACLs #1349

Merged
merged 1 commit into from
Jan 30, 2018
Merged

[sonic-cfggen] Enhance ACL unit test to also test control plane (service) ACLs #1349

merged 1 commit into from
Jan 30, 2018

Conversation

jleveque
Copy link
Contributor

  • Also add a sample service ACL (SNMP) to all sample minigraphs which contained a sample dataplane ACL.

@jleveque jleveque self-assigned this Jan 29, 2018
@jleveque jleveque merged commit 8cf03b0 into sonic-net:master Jan 30, 2018
@jleveque jleveque deleted the service_acl_unit_tests branch January 30, 2018 19:19
@pollyhsu2git
Copy link
Contributor

@jleveque, we have a couple of questions that need your help to clarify~

  1. Our testing department has been testing the branch, 201712br with sonic-mgmt patched sonic-mgmt PR#436 (https://github.com/Azure/sonic-mgmt/pull/436/files), and reported that the new test case, service_acl.yml failed upon checking for existence of /etc/sonic/acl.json.
  2. Do we need your sonic-buildimage PR#1349 here for (1)? If so, will it be merged into the branch, 201712br?

yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jan 8, 2021
@yxieca
[utilities] advance utilities submodule head
d7fb381 
- (HEAD, github/master) [storyteller] adding a grep wrapper with predefined scenarios (sonic-net#1349)
- Adding global-timeout, individual command timeout, log files collection (sonic-net#1249)
- Add FW dump with new SAI implementation (sonic-net#1338)
- [unit test][pfcwd] Fix tests that require sudo access (sonic-net#1340)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Jan 8, 2021
Merged
yxieca added a commit that referenced this pull request Jan 11, 2021
@yxieca
[utilities] advance utilities submodule head (#6402)
2816515 
- (HEAD, github/master) [storyteller] adding a grep wrapper with predefined scenarios (#1349)
- Adding global-timeout, individual command timeout, log files collection (#1249)
- Add FW dump with new SAI implementation (#1338)
- [unit test][pfcwd] Fix tests that require sudo access (#1340)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
daall pushed a commit that referenced this pull request Jan 11, 2021
@yxieca @daall
[utilities] advance utilities submodule head (#6402)
9da8b0f 
- (HEAD, github/master) [storyteller] adding a grep wrapper with predefined scenarios (#1349)
- Adding global-timeout, individual command timeout, log files collection (#1249)
- Add FW dump with new SAI implementation (#1338)
- [unit test][pfcwd] Fix tests that require sudo access (#1340)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@yxieca
[storyteller] adding a grep wrapper with predefined scenarios (sonic-…
0a4365a 
…net#1349)

* [storyteller] adding a grep wrapper with predefined scenarios

Introduce storyteller tool to grep syslog (or any other logs) for
a story line of a certain scenario.

Defined scenarios are:
- reboot  : device reboot related events.
- service : service start/stop events.
- link    : link up/down events.
- lag     : LAG up/down events.
- bgp     : BGP config change events.
- crash   : process/service crash events.

Unmatched cateory is used as grepping regex directly.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@shlomibitton shlomibitton mentioned this pull request Jun 14, 2021
Merged
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@gitsabari @tapashdas
Mclag enhacements (sonic-net#1349)
72892e4 
* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

* updated mclag port isolate platform check function

* MCLAG Unique IP Changes.

* updated mclagsyncd

* resolved compilation issues with master branch

* updated mclagsyncd merge issue

* addressed review comments

* addressed review comments

* fixed build issues with armhf platform

* fixed build issues with armhf platform

* fixed build issue

* fixed build issue

* addressed review comments

* addressed review comments

* removed unused code

Co-authored-by: Tapash Das <tapash.das@broadcom.com>
yxieca pushed a commit that referenced this pull request Feb 21, 2024
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
1a01724 
…tically (#18140)

src/sonic-sairedis

* 5c05e23 - (HEAD -> 202311, origin/202311) [SAI] Move SAI submodule to v1.13.3 (#1349) (2 hours ago) [Kamil Cudnik]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoyl-ms taoyl-ms taoyl-ms approved these changes

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleveque @pollyhsu2git @lguohan @taoyl-ms