rsyslog to start after interfaces-config #13503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Jan 27, 2023
|
Cherry-pick PR to 202211: #13528 |
|
Cherry-pick PR to 202205: #13529 |
This was referenced Jan 27, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 27, 2023
Fixes sonic-net#12408 Why I did it We are running into sonic-net#12408 very frequently. This results in no syslogs from any containers as rsyslog server could not start. some of the sonic-mgmt scripts look for log statements and error out if log is not present. Interfaces-config service configures the loopback interface along with other interfaces. rsyslog-config reads ip address of loopback interface and generates /etc/rsyslog.conf. When this race condition happens, lo interface ip is not yet programmed and rsyslog-config ends up writing UDP server as null in /etc/rsyslog.conf. How I did it rsyslog-config service is started after interfaces-config service. How to verify it Did multiple reboots and verified that $UDPServerAddress is valid.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 27, 2023
Fixes sonic-net#12408 Why I did it We are running into sonic-net#12408 very frequently. This results in no syslogs from any containers as rsyslog server could not start. some of the sonic-mgmt scripts look for log statements and error out if log is not present. Interfaces-config service configures the loopback interface along with other interfaces. rsyslog-config reads ip address of loopback interface and generates /etc/rsyslog.conf. When this race condition happens, lo interface ip is not yet programmed and rsyslog-config ends up writing UDP server as null in /etc/rsyslog.conf. How I did it rsyslog-config service is started after interfaces-config service. How to verify it Did multiple reboots and verified that $UDPServerAddress is valid.
mssonicbld
added a commit
that referenced
this pull request
Jan 27, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Jan 27, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12408
Why I did it
We are running into #12408 very frequently.
This results in no syslogs from any containers as rsyslog server could not start.
some of the sonic-mgmt scripts look for log statements and error out if log is not present.
Interfaces-configservice configures the loopback interface along with other interfaces.rsyslog-configreads ip address of loopback interface and generates/etc/rsyslog.conf. When this race condition happens,lointerface ip is not yet programmed andrsyslog-configends up writing UDP server asnullin/etc/rsyslog.conf.How I did it
rsyslog-config service is started after interfaces-config service.
How to verify it
Did multiple reboots and verified that
$UDPServerAddressis valid.Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)