Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recycle ports required for egress mirroring #13967

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

arista-nwolfe
Copy link
Contributor

@arista-nwolfe arista-nwolfe commented Feb 23, 2023

Why I did it

Support Egress Mirroring on supported Arista platforms

How I did it

Add necessary soc properties for egress mirroring recycle ports to be created

How to verify it

Ran the egress everflow tests and saw they now pass

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arista-nwolfe
Copy link
Contributor Author

arista-nwolfe commented Feb 28, 2023

I'm seeing some test failures with this change since #13831 merged.
I'm investigating how that change might impact this one.
In the meantime let's not merge this yet.

Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
@arista-nwolfe
Copy link
Contributor Author

I didn't have the complete list of soc properties for jr2-a7280cr3. Updated in the latest commit.

@arista-nwolfe
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui
Copy link
Contributor

rlhui commented Mar 15, 2023

@arista-nwolfe - are we still not to merge this one?

@arista-nwolfe
Copy link
Contributor Author

This one is safe to merge now, we resolved the issue we were seeing with jr2-a7280cr3.
Please feel free to merge when possible.

@kenneth-arista
Copy link
Contributor

@arlakshm can you or someone merge this ?

@arlakshm
Copy link
Contributor

arlakshm commented Apr 3, 2023

@lguohan, can you help merge this PR?

@lguohan lguohan merged commit 990993e into sonic-net:master Apr 6, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 19, 2023
…onic-net#13967)

Why I did it
Support Egress Mirroring on supported Arista platforms

How I did it
Add necessary soc properties for egress mirroring recycle ports to be created

Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #14731

@mssonicbld
Copy link
Collaborator

@arista-nwolfe PR conflicts with 202211 branch

@arista-nwolfe
Copy link
Contributor Author

I created a PR for 202211 here: #14791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants